* [PATCH] drm/amd/display: add proper error message for vblank init
@ 2025-03-21 11:37 Saleemkhan Jamadar
2025-03-21 12:52 ` Rodrigo Siqueira
2025-03-21 14:10 ` Mario Limonciello
0 siblings, 2 replies; 3+ messages in thread
From: Saleemkhan Jamadar @ 2025-03-21 11:37 UTC (permalink / raw)
To: alexander.deucher, Christian.Koenig, amd-gfx
Cc: aurabindo.pillai, mario.limonciello, alex.hung,
saleemkhan.jamadar
Update message to identifiy the vblank initialization fail case
Signed-off-by: Saleemkhan Jamadar <saleemkhan.jamadar@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 8dd9bf58eac5..3decf1973c7d 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -2218,7 +2218,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
if (drm_vblank_init(adev_to_drm(adev), adev->dm.display_indexes_num)) {
DRM_ERROR(
- "amdgpu: failed to initialize sw for display support.\n");
+ "amdgpu: failed to initialize vblank sw for display support.\n");
goto error;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amd/display: add proper error message for vblank init
2025-03-21 11:37 [PATCH] drm/amd/display: add proper error message for vblank init Saleemkhan Jamadar
@ 2025-03-21 12:52 ` Rodrigo Siqueira
2025-03-21 14:10 ` Mario Limonciello
1 sibling, 0 replies; 3+ messages in thread
From: Rodrigo Siqueira @ 2025-03-21 12:52 UTC (permalink / raw)
To: Saleemkhan Jamadar
Cc: alexander.deucher, Christian.Koenig, amd-gfx, aurabindo.pillai,
mario.limonciello, alex.hung
On 03/21, Saleemkhan Jamadar wrote:
> Update message to identifiy the vblank initialization fail case
>
> Signed-off-by: Saleemkhan Jamadar <saleemkhan.jamadar@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 8dd9bf58eac5..3decf1973c7d 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -2218,7 +2218,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
>
> if (drm_vblank_init(adev_to_drm(adev), adev->dm.display_indexes_num)) {
> DRM_ERROR(
> - "amdgpu: failed to initialize sw for display support.\n");
> + "amdgpu: failed to initialize vblank sw for display support.\n");
> goto error;
> }
>
> --
> 2.34.1
>
Reviewed-by: Rodrigo Siqueira <siqueira@igalia.com>
--
Rodrigo Siqueira
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amd/display: add proper error message for vblank init
2025-03-21 11:37 [PATCH] drm/amd/display: add proper error message for vblank init Saleemkhan Jamadar
2025-03-21 12:52 ` Rodrigo Siqueira
@ 2025-03-21 14:10 ` Mario Limonciello
1 sibling, 0 replies; 3+ messages in thread
From: Mario Limonciello @ 2025-03-21 14:10 UTC (permalink / raw)
To: Saleemkhan Jamadar, alexander.deucher, Christian.Koenig, amd-gfx
Cc: aurabindo.pillai, alex.hung
On 3/21/2025 06:37, Saleemkhan Jamadar wrote:
> Update message to identifiy the vblank initialization fail case
>
> Signed-off-by: Saleemkhan Jamadar <saleemkhan.jamadar@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 8dd9bf58eac5..3decf1973c7d 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -2218,7 +2218,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
>
> if (drm_vblank_init(adev_to_drm(adev), adev->dm.display_indexes_num)) {
> DRM_ERROR(
> - "amdgpu: failed to initialize sw for display support.\n");
> + "amdgpu: failed to initialize vblank sw for display support.\n");
> goto error;
> }
>
While touching this could you please swap away from DRM_ERROR() to
drm_err()?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-21 14:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-21 11:37 [PATCH] drm/amd/display: add proper error message for vblank init Saleemkhan Jamadar
2025-03-21 12:52 ` Rodrigo Siqueira
2025-03-21 14:10 ` Mario Limonciello
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).