[PATCH] drm/amdgpu: hide VRAM sysfs attributes on GPUs without VRAM

[PATCH] drm/amdgpu: hide VRAM sysfs attributes on GPUs without VRAM

[Christian König]

Otherwise accessing them can cause a crash.

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
index a5adb2ed9b3c..9d934c07fa6b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
@@ -234,6 +234,9 @@ static umode_t amdgpu_vram_attrs_is_visible(struct kobject *kobj,
 	    !adev->gmc.vram_vendor)
 		return 0;
 
+	if (!ttm_resource_manager_used(&adev->mman.vram_mgr.manager))
+		return 0;
+
 	return attr->mode;
 }
 
-- 
2.43.0

RE: [PATCH] drm/amdgpu: hide VRAM sysfs attributes on GPUs without VRAM

[Gadre, Mangesh]

[AMD Official Use Only - AMD Internal Distribution Only]

Tested-by: Mangesh Gadre <Mangesh.Gadre@amd.com>

>-----Original Message-----
>From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Christian
>König
>Sent: Tuesday, October 7, 2025 2:49 PM
>To: Deucher, Alexander <Alexander.Deucher@amd.com>; amd-
>gfx@lists.freedesktop.org
>Subject: [PATCH] drm/amdgpu: hide VRAM sysfs attributes on GPUs without VRAM
>
>Otherwise accessing them can cause a crash.
>
>Signed-off-by: Christian König <christian.koenig@amd.com>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>index a5adb2ed9b3c..9d934c07fa6b 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>@@ -234,6 +234,9 @@ static umode_t amdgpu_vram_attrs_is_visible(struct
>kobject *kobj,
>           !adev->gmc.vram_vendor)
>               return 0;
>
>+      if (!ttm_resource_manager_used(&adev->mman.vram_mgr.manager))
>+              return 0;
>+
>       return attr->mode;
> }
>
>--
>2.43.0

Re: [PATCH] drm/amdgpu: hide VRAM sysfs attributes on GPUs without VRAM

[Alex Deucher]

On Tue, Oct 7, 2025 at 5:26 AM Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> Otherwise accessing them can cause a crash.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>

Acked-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
> index a5adb2ed9b3c..9d934c07fa6b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
> @@ -234,6 +234,9 @@ static umode_t amdgpu_vram_attrs_is_visible(struct kobject *kobj,
>             !adev->gmc.vram_vendor)
>                 return 0;
>
> +       if (!ttm_resource_manager_used(&adev->mman.vram_mgr.manager))
> +               return 0;
> +
>         return attr->mode;
>  }
>
> --
> 2.43.0
>

Re: [PATCH] drm/amdgpu: hide VRAM sysfs attributes on GPUs without VRAM

[Christian König]

Arun sorry I should have CCed you in the first place.

Please take a look as well.

Thanks,
Christian.

On 07.10.25 11:19, Christian König wrote:
> Otherwise accessing them can cause a crash.
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
> index a5adb2ed9b3c..9d934c07fa6b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
> @@ -234,6 +234,9 @@ static umode_t amdgpu_vram_attrs_is_visible(struct kobject *kobj,
>  	    !adev->gmc.vram_vendor)
>  		return 0;
>  
> +	if (!ttm_resource_manager_used(&adev->mman.vram_mgr.manager))
> +		return 0;
> +
>  	return attr->mode;
>  }
>  

Re: [PATCH] drm/amdgpu: hide VRAM sysfs attributes on GPUs without VRAM

[Arunpravin Paneer Selvam]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

Hi Christian,

No problem. The patch looks good.

Reviewed-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>

Thanks,
Arun.
On 10/8/2025 8:30 PM, Christian König wrote:
> Arun sorry I should have CCed you in the first place.
>
> Please take a look as well.
>
> Thanks,
> Christian.
>
> On 07.10.25 11:19, Christian König wrote:
>> Otherwise accessing them can cause a crash.
>>
>> Signed-off-by: Christian König<christian.koenig@amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>> index a5adb2ed9b3c..9d934c07fa6b 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
>> @@ -234,6 +234,9 @@ static umode_t amdgpu_vram_attrs_is_visible(struct kobject *kobj,
>>   	    !adev->gmc.vram_vendor)
>>   		return 0;
>>   
>> +	if (!ttm_resource_manager_used(&adev->mman.vram_mgr.manager))
>> +		return 0;
>> +
>>   	return attr->mode;
>>   }
>>   

[-- Attachment #2: Type: text/html, Size: 1758 bytes --]