From: "Christian König" <christian.koenig@amd.com>
To: YuBiao Wang <YuBiao.Wang@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>,
Feifei Xu <Feifei.Xu@amd.com>,
horace.chen@amd.com, Tuikov Luben <Luben.Tuikov@amd.com>,
Deucher Alexander <Alexander.Deucher@amd.com>,
Evan Quan <Evan.Quan@amd.com>, Monk Liu <Monk.Liu@amd.com>,
Hawking Zhang <Hawking.Zhang@amd.com>
Subject: Re: [PATCH] drm/amdgpu: set default num_kcq to 2 under sriov
Date: Fri, 5 May 2023 10:34:43 +0200 [thread overview]
Message-ID: <cb798677-5c84-05df-665a-3743f1569d8b@amd.com> (raw)
In-Reply-To: <20230505063939.2485298-1-YuBiao.Wang@amd.com>
Am 05.05.23 um 08:39 schrieb YuBiao Wang:
> The number of kernel queues has impact on the latency under sriov
> usecase. So to reduce the latency we set the default num_kcq = 2 under
> sriov if not set manually.
>
> Signed-off-by: YuBiao Wang <YuBiao.Wang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> index 1311e42ab8e9..d0ad7cb0fa05 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -68,6 +68,9 @@ void amdgpu_virt_init_setting(struct amdgpu_device *adev)
> /* enable mcbp for sriov */
> amdgpu_mcbp = 1;
>
> + /* Reduce kcq number to 2 to reduce latency */
> + if (amdgpu_num_kcq == -1)
> + amdgpu_num_kcq = 2;
> }
>
> void amdgpu_virt_kiq_reg_write_reg_wait(struct amdgpu_device *adev,
prev parent reply other threads:[~2023-05-05 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 6:39 [PATCH] drm/amdgpu: set default num_kcq to 2 under sriov YuBiao Wang
2023-05-05 8:34 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb798677-5c84-05df-665a-3743f1569d8b@amd.com \
--to=christian.koenig@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Andrey.Grodzovsky@amd.com \
--cc=Evan.Quan@amd.com \
--cc=Feifei.Xu@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Luben.Tuikov@amd.com \
--cc=Monk.Liu@amd.com \
--cc=YuBiao.Wang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=horace.chen@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox