* [PATCH] drm/amdgpu: set default num_kcq to 2 under sriov
@ 2023-05-05 6:39 YuBiao Wang
2023-05-05 8:34 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: YuBiao Wang @ 2023-05-05 6:39 UTC (permalink / raw)
To: amd-gfx
Cc: YuBiao Wang, Andrey Grodzovsky, Feifei Xu, horace.chen,
Tuikov Luben, Deucher Alexander, Evan Quan, Christian König,
Monk Liu, Hawking Zhang
The number of kernel queues has impact on the latency under sriov
usecase. So to reduce the latency we set the default num_kcq = 2 under
sriov if not set manually.
Signed-off-by: YuBiao Wang <YuBiao.Wang@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 1311e42ab8e9..d0ad7cb0fa05 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -68,6 +68,9 @@ void amdgpu_virt_init_setting(struct amdgpu_device *adev)
/* enable mcbp for sriov */
amdgpu_mcbp = 1;
+ /* Reduce kcq number to 2 to reduce latency */
+ if (amdgpu_num_kcq == -1)
+ amdgpu_num_kcq = 2;
}
void amdgpu_virt_kiq_reg_write_reg_wait(struct amdgpu_device *adev,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdgpu: set default num_kcq to 2 under sriov
2023-05-05 6:39 [PATCH] drm/amdgpu: set default num_kcq to 2 under sriov YuBiao Wang
@ 2023-05-05 8:34 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2023-05-05 8:34 UTC (permalink / raw)
To: YuBiao Wang, amd-gfx
Cc: Andrey Grodzovsky, Feifei Xu, horace.chen, Tuikov Luben,
Deucher Alexander, Evan Quan, Monk Liu, Hawking Zhang
Am 05.05.23 um 08:39 schrieb YuBiao Wang:
> The number of kernel queues has impact on the latency under sriov
> usecase. So to reduce the latency we set the default num_kcq = 2 under
> sriov if not set manually.
>
> Signed-off-by: YuBiao Wang <YuBiao.Wang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> index 1311e42ab8e9..d0ad7cb0fa05 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -68,6 +68,9 @@ void amdgpu_virt_init_setting(struct amdgpu_device *adev)
> /* enable mcbp for sriov */
> amdgpu_mcbp = 1;
>
> + /* Reduce kcq number to 2 to reduce latency */
> + if (amdgpu_num_kcq == -1)
> + amdgpu_num_kcq = 2;
> }
>
> void amdgpu_virt_kiq_reg_write_reg_wait(struct amdgpu_device *adev,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-05 8:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-05 6:39 [PATCH] drm/amdgpu: set default num_kcq to 2 under sriov YuBiao Wang
2023-05-05 8:34 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox