From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Sonny Jiang <sonny.jiang@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/7] drm amdgpu: SI UVD PACKET_TYPE0
Date: Mon, 22 Jun 2020 20:14:55 +0200 [thread overview]
Message-ID: <cec4c40b-73e9-82d2-bf22-de92d8257eea@gmail.com> (raw)
In-Reply-To: <20200617220016.4844-1-sonny.jiang@amd.com>
Your Signed-of-by line is missing and a one liner commit message would
be nice to have. Something like "Cleaning up radeon leftovers."
With that fixed the patch is Reviewed-by: Christian König
<christian.koenig@amd.com>.
Am 18.06.20 um 00:00 schrieb Sonny Jiang:
> ---
> drivers/gpu/drm/amd/amdgpu/sid.h | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sid.h b/drivers/gpu/drm/amd/amdgpu/sid.h
> index 7cf12adb3915..75b5d441b628 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sid.h
> +++ b/drivers/gpu/drm/amd/amdgpu/sid.h
> @@ -1646,9 +1646,10 @@
> /*
> * PM4
> */
> -#define PACKET0(reg, n) ((RADEON_PACKET_TYPE0 << 30) | \
> - (((reg) >> 2) & 0xFFFF) | \
> - ((n) & 0x3FFF) << 16)
> +#define PACKET_TYPE0 0
> +#define PACKET0(reg, n) ((PACKET_TYPE0 << 30) | \
> + ((reg) & 0xFFFF) | \
> + ((n) & 0x3FFF) << 16)
> #define CP_PACKET2 0x80000000
> #define PACKET2_PAD_SHIFT 0
> #define PACKET2_PAD_MASK (0x3fffffff << 0)
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-06-22 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 22:00 [PATCH 1/7] drm amdgpu: SI UVD PACKET_TYPE0 Sonny Jiang
2020-06-17 22:00 ` [PATCH 2/7] drm amdgpu: SI UVD registers Sonny Jiang
2020-06-17 22:00 ` [PATCH 3/7] drm amdgpu: SI UVD v3_1 Sonny Jiang
2020-06-17 22:00 ` [PATCH 4/7] drm amdgpu: SI UVD context rreg/wreg Sonny Jiang
2020-06-17 22:00 ` [PATCH 5/7] drm amdgpu: SI UVD add uvd_v3_1 to makefile Sonny Jiang
2020-06-17 22:00 ` [PATCH 6/7] drm amdgpu: SI UVD enable for Oland Sonny Jiang
2020-06-17 22:00 ` [PATCH 7/7] drm amdgpu: SI UVD enabled on Verde, Tahiti, Pitcairn Sonny Jiang
2020-06-18 4:31 ` [PATCH 1/7] drm amdgpu: SI UVD PACKET_TYPE0 Alex Deucher
2020-06-22 18:14 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cec4c40b-73e9-82d2-bf22-de92d8257eea@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=sonny.jiang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox