AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 0/3] drm: Drop unused include of <drm/drm_pciids.h>
@ 2026-04-30 10:45 Uwe Kleine-König (The Capable Hub)
  2026-04-30 10:45 ` [PATCH v1 1/3] drm/amdgpu: " Uwe Kleine-König (The Capable Hub)
  2026-05-06  7:28 ` [PATCH v1 0/3] drm: " Thomas Zimmermann
  0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-04-30 10:45 UTC (permalink / raw)
  To: Alex Deucher, Christian König, Patrik Jakobsson,
	Maarten Lankhorst, Dave Airlie
  Cc: David Airlie, Simona Vetter, amd-gfx, dri-devel, linux-kernel,
	Markus Schneider-Pargmann, Maxime Ripard, Thomas Zimmermann,
	Jocelyn Falempe

Hello,

<drm/drm_pciids.h> is only actually used in the radeon driver but
included in several others. This series drops these includes.

The obvious continuation would be to fold the definition of
radeon_PCI_IDS into the only .c file using it. But I post-pone that
until
https://lore.kernel.org/all/20260430102958.136859-2-u.kleine-koenig@baylibre.com/
is out of the way.

There are no dependencies between the patches, so I suggest that each
maintainer team applies their material to their own tree at their own
pace.

To state the obvious: This is merge window material.

Best regards
Uwe

Uwe Kleine-König (The Capable Hub) (3):
  drm/amdgpu: Drop unused include of <drm/drm_pciids.h>
  drm/gma500: Drop unused include of <drm/drm_pciids.h>
  drm/mgag200: Drop unused include of <drm/drm_pciids.h>

 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
 drivers/gpu/drm/gma500/psb_drv.c        | 1 -
 drivers/gpu/drm/mgag200/mgag200_drv.c   | 1 -
 3 files changed, 3 deletions(-)


base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
-- 
2.47.3


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v1 1/3] drm/amdgpu: Drop unused include of <drm/drm_pciids.h>
  2026-04-30 10:45 [PATCH v1 0/3] drm: Drop unused include of <drm/drm_pciids.h> Uwe Kleine-König (The Capable Hub)
@ 2026-04-30 10:45 ` Uwe Kleine-König (The Capable Hub)
  2026-05-06  7:28 ` [PATCH v1 0/3] drm: " Thomas Zimmermann
  1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-04-30 10:45 UTC (permalink / raw)
  To: Alex Deucher, Christian König
  Cc: David Airlie, Simona Vetter, amd-gfx, dri-devel, linux-kernel,
	Markus Schneider-Pargmann

The <drm/drm_pciids.h> header only defines radeon_PCI_IDS which isn't
used in the amdgpu driver. So drop the useless include statement.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 8b71834a73df..1239fb32311f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -28,7 +28,6 @@
 #include <drm/drm_fbdev_ttm.h>
 #include <drm/drm_gem.h>
 #include <drm/drm_managed.h>
-#include <drm/drm_pciids.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
 
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 0/3] drm: Drop unused include of <drm/drm_pciids.h>
  2026-04-30 10:45 [PATCH v1 0/3] drm: Drop unused include of <drm/drm_pciids.h> Uwe Kleine-König (The Capable Hub)
  2026-04-30 10:45 ` [PATCH v1 1/3] drm/amdgpu: " Uwe Kleine-König (The Capable Hub)
@ 2026-05-06  7:28 ` Thomas Zimmermann
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2026-05-06  7:28 UTC (permalink / raw)
  To: Uwe Kleine-König (The Capable Hub), Alex Deucher,
	Christian König, Patrik Jakobsson, Maarten Lankhorst,
	Dave Airlie
  Cc: David Airlie, Simona Vetter, amd-gfx, dri-devel, linux-kernel,
	Markus Schneider-Pargmann, Maxime Ripard, Jocelyn Falempe

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Am 30.04.26 um 12:45 schrieb Uwe Kleine-König (The Capable Hub):
> Hello,
>
> <drm/drm_pciids.h> is only actually used in the radeon driver but
> included in several others. This series drops these includes.
>
> The obvious continuation would be to fold the definition of
> radeon_PCI_IDS into the only .c file using it. But I post-pone that
> until
> https://lore.kernel.org/all/20260430102958.136859-2-u.kleine-koenig@baylibre.com/
> is out of the way.
>
> There are no dependencies between the patches, so I suggest that each
> maintainer team applies their material to their own tree at their own
> pace.
>
> To state the obvious: This is merge window material.
>
> Best regards
> Uwe
>
> Uwe Kleine-König (The Capable Hub) (3):
>    drm/amdgpu: Drop unused include of <drm/drm_pciids.h>
>    drm/gma500: Drop unused include of <drm/drm_pciids.h>
>    drm/mgag200: Drop unused include of <drm/drm_pciids.h>
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
>   drivers/gpu/drm/gma500/psb_drv.c        | 1 -
>   drivers/gpu/drm/mgag200/mgag200_drv.c   | 1 -
>   3 files changed, 3 deletions(-)
>
>
> base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-05-06  7:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-30 10:45 [PATCH v1 0/3] drm: Drop unused include of <drm/drm_pciids.h> Uwe Kleine-König (The Capable Hub)
2026-04-30 10:45 ` [PATCH v1 1/3] drm/amdgpu: " Uwe Kleine-König (The Capable Hub)
2026-05-06  7:28 ` [PATCH v1 0/3] drm: " Thomas Zimmermann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox