Re: [PATCH v7 04/15] drm/amd/display: use drm_edid helper to set analog EDID caps

["Timur Kristóf" <timur.kristof@gmail.com>]

On Thu, 2025-11-06 at 13:49 -0300, Melissa Wen wrote:
> Use drm_edid_is_digital helper instead of open-coded mask.
> 
> Signed-off-by: Melissa Wen <mwen@igalia.com>

Thanks for catching this, I was not aware of this helper.

Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> index 7d05cff08233..05e5f51b0a90 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> @@ -135,7 +135,7 @@ enum dc_edid_status dm_helpers_parse_edid_caps(
>  	edid_caps->serial_number =
> le32_to_cpu(product_id.serial_number);
>  	edid_caps->manufacture_week =
> product_id.week_of_manufacture;
>  	edid_caps->manufacture_year =
> product_id.year_of_manufacture;
> -	edid_caps->analog = !(edid_buf->input &
> DRM_EDID_INPUT_DIGITAL);
> +	edid_caps->analog = !drm_edid_is_digital(drm_edid);
>  
>  	drm_edid_get_monitor_name(edid_buf,
>  				  edid_caps->display_name,