From: Mario Limonciello <mario.limonciello@amd.com>
To: Melissa Wen <mwen@igalia.com>,
Harry Wentland <harry.wentland@amd.com>,
Alex Hung <alex.hung@amd.com>,
Rodrigo Siqueira <siqueira@igalia.com>,
airlied@gmail.com, alexander.deucher@amd.com,
andrzej.hajda@intel.com, christian.koenig@amd.com,
jernej.skrabec@gmail.com, jonas@kwiboo.se,
Laurent.pinchart@ideasonboard.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
neil.armstrong@linaro.org, rfoss@kernel.org, simona@ffwll.ch,
sunpeng.li@amd.com, tzimmermann@suse.de
Cc: Michel Daenzer <michel.daenzer@mailbox.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kernel-dev@igalia.com
Subject: Re: [PATCH v7 04/15] drm/amd/display: use drm_edid helper to set analog EDID caps
Date: Wed, 12 Nov 2025 09:46:27 -0600 [thread overview]
Message-ID: <ef070b8e-602a-4d6d-8cfe-0fa74fe38563@amd.com> (raw)
In-Reply-To: <20251106165536.161662-5-mwen@igalia.com>
On 11/6/25 10:49 AM, Melissa Wen wrote:
> Use drm_edid_is_digital helper instead of open-coded mask.
>
> Signed-off-by: Melissa Wen <mwen@igalia.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> index 7d05cff08233..05e5f51b0a90 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
> @@ -135,7 +135,7 @@ enum dc_edid_status dm_helpers_parse_edid_caps(
> edid_caps->serial_number = le32_to_cpu(product_id.serial_number);
> edid_caps->manufacture_week = product_id.week_of_manufacture;
> edid_caps->manufacture_year = product_id.year_of_manufacture;
> - edid_caps->analog = !(edid_buf->input & DRM_EDID_INPUT_DIGITAL);
> + edid_caps->analog = !drm_edid_is_digital(drm_edid);
>
> drm_edid_get_monitor_name(edid_buf,
> edid_caps->display_name,
next prev parent reply other threads:[~2025-11-12 15:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 16:49 [PATCH v7 00/15] drm/amd/display: more drm_edid to AMD display driver Melissa Wen
2025-11-06 16:49 ` [PATCH v7 01/15] drm/amd/display: make sure drm_edid stored in aconnector doesn't leak Melissa Wen
2025-11-06 16:49 ` [PATCH v7 02/15] drm/amd/display: start using drm_edid helpers to parse EDID caps Melissa Wen
2025-11-11 13:40 ` Timur Kristóf
2025-11-06 16:49 ` [PATCH v7 03/15] drm/amd/display: use drm_edid_product_id for parsing EDID product info Melissa Wen
2025-11-12 15:45 ` Mario Limonciello
2025-11-06 16:49 ` [PATCH v7 04/15] drm/amd/display: use drm_edid helper to set analog EDID caps Melissa Wen
2025-11-11 13:38 ` Timur Kristóf
2025-11-12 15:46 ` Mario Limonciello [this message]
2025-11-06 16:49 ` [PATCH v7 05/15] drm/edid: introduce a helper that gets monitor name from drm_edid Melissa Wen
2025-11-06 16:49 ` [PATCH v7 06/15] drm/amd/display: get panel id with drm_edid helper Melissa Wen
2025-11-11 13:46 ` Timur Kristóf
2025-11-06 16:49 ` [PATCH v7 07/15] drm/amd/display: get SAD from drm_eld when parsing EDID caps Melissa Wen
2025-11-11 13:47 ` Timur Kristóf
2025-11-06 16:49 ` [PATCH v7 08/15] drm/amd/display: get SADB " Melissa Wen
2025-11-06 16:49 ` [PATCH v7 09/15] drm/amd/display: simplify dm_helpers_parse_edid_caps signature Melissa Wen
2025-11-06 16:49 ` [PATCH v7 10/15] drm/amd/display: change DC functions to accept private types for edid Melissa Wen
2025-11-06 16:49 ` [PATCH v7 11/15] drm/amd/display: add DM helpers to handle EDID in DC via drm_edid helpers Melissa Wen
2025-11-06 16:49 ` [PATCH v7 12/15] drm/amd/display: create a function to fill dc_sink with edid data Melissa Wen
2025-11-06 16:49 ` [PATCH v7 13/15] drm/edid: introduce a helper that compares edid data from two drm_edid Melissa Wen
2025-11-06 16:49 ` [PATCH v7 14/15] drm/amd/display: add drm_edid to dc_sink Melissa Wen
2025-11-11 13:44 ` Timur Kristóf
2025-11-06 16:49 ` [PATCH v7 15/15] drm/amd/display: move dc_sink from dc_edid to drm_edid Melissa Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef070b8e-602a-4d6d-8cfe-0fa74fe38563@amd.com \
--to=mario.limonciello@amd.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrzej.hajda@intel.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=jani.nikula@linux.intel.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel-dev@igalia.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michel.daenzer@mailbox.org \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox