Re: [PATCH] drm/amd/amdgpu: Move enum for VDD board

["Lazar, Lijo" <lijo.lazar@amd.com>]

On 11/28/2025 5:58 PM, Asad Kamal wrote:
> Move AMDGPU_PP_SENSOR_VDDBOARD below already existing
> members to maintain backward compatibility
> 
> Fixes: 96ac487c1200 ("drm/amd/pm: Add board voltage node to hwmon")
> 

Please remove this as this is not a fix in driver. This is done only 
because client like umr keeps a separate copy of driver definitions 
instead of directly using driver header. A client code is not supposed 
to keep a local copy and assume driver follows the same order.


> Signed-off-by: Asad Kamal <asad.kamal@amd.com>

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>

Thanks,
Lijo

> ---
>   drivers/gpu/drm/amd/include/kgd_pp_interface.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/include/kgd_pp_interface.h b/drivers/gpu/drm/amd/include/kgd_pp_interface.h
> index 92477120c28d..2a454f06c022 100644
> --- a/drivers/gpu/drm/amd/include/kgd_pp_interface.h
> +++ b/drivers/gpu/drm/amd/include/kgd_pp_interface.h
> @@ -136,7 +136,6 @@ enum amd_pp_sensors {
>   	AMDGPU_PP_SENSOR_CPU_CLK,
>   	AMDGPU_PP_SENSOR_VDDNB,
>   	AMDGPU_PP_SENSOR_VDDGFX,
> -	AMDGPU_PP_SENSOR_VDDBOARD,
>   	AMDGPU_PP_SENSOR_UVD_VCLK,
>   	AMDGPU_PP_SENSOR_UVD_DCLK,
>   	AMDGPU_PP_SENSOR_VCE_ECCLK,
> @@ -162,6 +161,7 @@ enum amd_pp_sensors {
>   	AMDGPU_PP_SENSOR_PEAK_PSTATE_SCLK,
>   	AMDGPU_PP_SENSOR_PEAK_PSTATE_MCLK,
>   	AMDGPU_PP_SENSOR_VCN_LOAD,
> +	AMDGPU_PP_SENSOR_VDDBOARD,
>   	AMDGPU_PP_SENSOR_NODEPOWERLIMIT,
>   	AMDGPU_PP_SENSOR_NODEPOWER,
>   	AMDGPU_PP_SENSOR_GPPTRESIDENCY,