* [PATCH] drm/amd/amdgpu: Move enum for VDD board
@ 2025-11-28 12:28 Asad Kamal
2025-12-01 4:39 ` Lazar, Lijo
0 siblings, 1 reply; 2+ messages in thread
From: Asad Kamal @ 2025-11-28 12:28 UTC (permalink / raw)
To: amd-gfx
Cc: lijo.lazar, hawking.zhang, le.ma, shiwu.zhang, alexander.deucher,
asad.kamal, tom.stdenis, pierre-eric.pelloux-prayer
Move AMDGPU_PP_SENSOR_VDDBOARD below already existing
members to maintain backward compatibility
Fixes: 96ac487c1200 ("drm/amd/pm: Add board voltage node to hwmon")
Signed-off-by: Asad Kamal <asad.kamal@amd.com>
---
drivers/gpu/drm/amd/include/kgd_pp_interface.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/include/kgd_pp_interface.h b/drivers/gpu/drm/amd/include/kgd_pp_interface.h
index 92477120c28d..2a454f06c022 100644
--- a/drivers/gpu/drm/amd/include/kgd_pp_interface.h
+++ b/drivers/gpu/drm/amd/include/kgd_pp_interface.h
@@ -136,7 +136,6 @@ enum amd_pp_sensors {
AMDGPU_PP_SENSOR_CPU_CLK,
AMDGPU_PP_SENSOR_VDDNB,
AMDGPU_PP_SENSOR_VDDGFX,
- AMDGPU_PP_SENSOR_VDDBOARD,
AMDGPU_PP_SENSOR_UVD_VCLK,
AMDGPU_PP_SENSOR_UVD_DCLK,
AMDGPU_PP_SENSOR_VCE_ECCLK,
@@ -162,6 +161,7 @@ enum amd_pp_sensors {
AMDGPU_PP_SENSOR_PEAK_PSTATE_SCLK,
AMDGPU_PP_SENSOR_PEAK_PSTATE_MCLK,
AMDGPU_PP_SENSOR_VCN_LOAD,
+ AMDGPU_PP_SENSOR_VDDBOARD,
AMDGPU_PP_SENSOR_NODEPOWERLIMIT,
AMDGPU_PP_SENSOR_NODEPOWER,
AMDGPU_PP_SENSOR_GPPTRESIDENCY,
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/amd/amdgpu: Move enum for VDD board
2025-11-28 12:28 [PATCH] drm/amd/amdgpu: Move enum for VDD board Asad Kamal
@ 2025-12-01 4:39 ` Lazar, Lijo
0 siblings, 0 replies; 2+ messages in thread
From: Lazar, Lijo @ 2025-12-01 4:39 UTC (permalink / raw)
To: Asad Kamal, amd-gfx
Cc: hawking.zhang, le.ma, shiwu.zhang, alexander.deucher, tom.stdenis,
pierre-eric.pelloux-prayer
On 11/28/2025 5:58 PM, Asad Kamal wrote:
> Move AMDGPU_PP_SENSOR_VDDBOARD below already existing
> members to maintain backward compatibility
>
> Fixes: 96ac487c1200 ("drm/amd/pm: Add board voltage node to hwmon")
>
Please remove this as this is not a fix in driver. This is done only
because client like umr keeps a separate copy of driver definitions
instead of directly using driver header. A client code is not supposed
to keep a local copy and assume driver follows the same order.
> Signed-off-by: Asad Kamal <asad.kamal@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/include/kgd_pp_interface.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/include/kgd_pp_interface.h b/drivers/gpu/drm/amd/include/kgd_pp_interface.h
> index 92477120c28d..2a454f06c022 100644
> --- a/drivers/gpu/drm/amd/include/kgd_pp_interface.h
> +++ b/drivers/gpu/drm/amd/include/kgd_pp_interface.h
> @@ -136,7 +136,6 @@ enum amd_pp_sensors {
> AMDGPU_PP_SENSOR_CPU_CLK,
> AMDGPU_PP_SENSOR_VDDNB,
> AMDGPU_PP_SENSOR_VDDGFX,
> - AMDGPU_PP_SENSOR_VDDBOARD,
> AMDGPU_PP_SENSOR_UVD_VCLK,
> AMDGPU_PP_SENSOR_UVD_DCLK,
> AMDGPU_PP_SENSOR_VCE_ECCLK,
> @@ -162,6 +161,7 @@ enum amd_pp_sensors {
> AMDGPU_PP_SENSOR_PEAK_PSTATE_SCLK,
> AMDGPU_PP_SENSOR_PEAK_PSTATE_MCLK,
> AMDGPU_PP_SENSOR_VCN_LOAD,
> + AMDGPU_PP_SENSOR_VDDBOARD,
> AMDGPU_PP_SENSOR_NODEPOWERLIMIT,
> AMDGPU_PP_SENSOR_NODEPOWER,
> AMDGPU_PP_SENSOR_GPPTRESIDENCY,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-01 4:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-28 12:28 [PATCH] drm/amd/amdgpu: Move enum for VDD board Asad Kamal
2025-12-01 4:39 ` Lazar, Lijo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox