From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Emily Deng <Emily.Deng-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: Temparary disable the sdma use pollmem feature for sriov.
Date: Fri, 19 Jan 2018 11:22:06 +0100 [thread overview]
Message-ID: <ea823ba5-5bf5-8ef2-40eb-bf763e9300f8@gmail.com> (raw)
In-Reply-To: <1516356864-2622-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org>
Am 19.01.2018 um 11:14 schrieb Emily Deng:
> It still has some serious issues(guest driver reload fail, etc),
> when use pollmem feature for sdma3.
>
> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> index 3e22ae4..0f8f614 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> @@ -1209,7 +1209,7 @@ static int sdma_v3_0_sw_init(void *handle)
> for (i = 0; i < adev->sdma.num_instances; i++) {
> ring = &adev->sdma.instance[i].ring;
> ring->ring_obj = NULL;
> - if (!amdgpu_sriov_vf(adev)) {
> + if (1) {
That needs a comment why we have it and I suggest writing this as:
/* Disabled for now because... */
if (true /* !amdgpu_sriov_vf(adev) */)
Regards,
Christian.
> ring->use_doorbell = true;
> ring->doorbell_index = (i == 0) ?
> AMDGPU_DOORBELL_sDMA_ENGINE0 : AMDGPU_DOORBELL_sDMA_ENGINE1;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2018-01-19 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 10:14 [PATCH] drm/amdgpu: Temparary disable the sdma use pollmem feature for sriov Emily Deng
[not found] ` <1516356864-2622-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org>
2018-01-19 10:22 ` Christian König [this message]
[not found] ` <ea823ba5-5bf5-8ef2-40eb-bf763e9300f8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-22 1:55 ` Deng, Emily
-- strict thread matches above, loose matches on Subject: below --
2018-01-19 10:15 Emily Deng
2018-01-19 10:18 Emily Deng
2018-01-19 10:20 Emily Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea823ba5-5bf5-8ef2-40eb-bf763e9300f8@gmail.com \
--to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Emily.Deng-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox