* [PATCH] drm/amdgpu: Temparary disable the sdma use pollmem feature for sriov.
@ 2018-01-19 10:14 Emily Deng
[not found] ` <1516356864-2622-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Emily Deng @ 2018-01-19 10:14 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Emily Deng
It still has some serious issues(guest driver reload fail, etc),
when use pollmem feature for sdma3.
Signed-off-by: Emily Deng <Emily.Deng@amd.com>
---
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
index 3e22ae4..0f8f614 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
@@ -1209,7 +1209,7 @@ static int sdma_v3_0_sw_init(void *handle)
for (i = 0; i < adev->sdma.num_instances; i++) {
ring = &adev->sdma.instance[i].ring;
ring->ring_obj = NULL;
- if (!amdgpu_sriov_vf(adev)) {
+ if (1) {
ring->use_doorbell = true;
ring->doorbell_index = (i == 0) ?
AMDGPU_DOORBELL_sDMA_ENGINE0 : AMDGPU_DOORBELL_sDMA_ENGINE1;
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/amdgpu: Temparary disable the sdma use pollmem feature for sriov.
@ 2018-01-19 10:15 Emily Deng
0 siblings, 0 replies; 6+ messages in thread
From: Emily Deng @ 2018-01-19 10:15 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Emily Deng
It still has some serious issues(guest driver reload fail, etc),
when use pollmem feature for sdma3.
Signed-off-by: Emily Deng <Emily.Deng@amd.com>
---
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
index 3e22ae4..0f8f614 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
@@ -1209,7 +1209,7 @@ static int sdma_v3_0_sw_init(void *handle)
for (i = 0; i < adev->sdma.num_instances; i++) {
ring = &adev->sdma.instance[i].ring;
ring->ring_obj = NULL;
- if (!amdgpu_sriov_vf(adev)) {
+ if (1) {
ring->use_doorbell = true;
ring->doorbell_index = (i == 0) ?
AMDGPU_DOORBELL_sDMA_ENGINE0 : AMDGPU_DOORBELL_sDMA_ENGINE1;
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/amdgpu: Temparary disable the sdma use pollmem feature for sriov.
@ 2018-01-19 10:18 Emily Deng
0 siblings, 0 replies; 6+ messages in thread
From: Emily Deng @ 2018-01-19 10:18 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Emily Deng
It still has some serious issues(guest driver reload fail, etc),
when use pollmem feature for sdma3.
Signed-off-by: Emily Deng <Emily.Deng@amd.com>
---
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
index 3e22ae4..0f8f614 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
@@ -1209,7 +1209,7 @@ static int sdma_v3_0_sw_init(void *handle)
for (i = 0; i < adev->sdma.num_instances; i++) {
ring = &adev->sdma.instance[i].ring;
ring->ring_obj = NULL;
- if (!amdgpu_sriov_vf(adev)) {
+ if (1) {
ring->use_doorbell = true;
ring->doorbell_index = (i == 0) ?
AMDGPU_DOORBELL_sDMA_ENGINE0 : AMDGPU_DOORBELL_sDMA_ENGINE1;
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/amdgpu: Temparary disable the sdma use pollmem feature for sriov.
@ 2018-01-19 10:20 Emily Deng
0 siblings, 0 replies; 6+ messages in thread
From: Emily Deng @ 2018-01-19 10:20 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Emily Deng
It still has some serious issues(guest driver reload fail, etc),
when use pollmem feature for sdma3.
Signed-off-by: Emily Deng <Emily.Deng@amd.com>
---
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
index 3e22ae4..0f8f614 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
@@ -1209,7 +1209,7 @@ static int sdma_v3_0_sw_init(void *handle)
for (i = 0; i < adev->sdma.num_instances; i++) {
ring = &adev->sdma.instance[i].ring;
ring->ring_obj = NULL;
- if (!amdgpu_sriov_vf(adev)) {
+ if (1) {
ring->use_doorbell = true;
ring->doorbell_index = (i == 0) ?
AMDGPU_DOORBELL_sDMA_ENGINE0 : AMDGPU_DOORBELL_sDMA_ENGINE1;
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Temparary disable the sdma use pollmem feature for sriov.
[not found] ` <1516356864-2622-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org>
@ 2018-01-19 10:22 ` Christian König
[not found] ` <ea823ba5-5bf5-8ef2-40eb-bf763e9300f8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Christian König @ 2018-01-19 10:22 UTC (permalink / raw)
To: Emily Deng, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Am 19.01.2018 um 11:14 schrieb Emily Deng:
> It still has some serious issues(guest driver reload fail, etc),
> when use pollmem feature for sdma3.
>
> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> index 3e22ae4..0f8f614 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> @@ -1209,7 +1209,7 @@ static int sdma_v3_0_sw_init(void *handle)
> for (i = 0; i < adev->sdma.num_instances; i++) {
> ring = &adev->sdma.instance[i].ring;
> ring->ring_obj = NULL;
> - if (!amdgpu_sriov_vf(adev)) {
> + if (1) {
That needs a comment why we have it and I suggest writing this as:
/* Disabled for now because... */
if (true /* !amdgpu_sriov_vf(adev) */)
Regards,
Christian.
> ring->use_doorbell = true;
> ring->doorbell_index = (i == 0) ?
> AMDGPU_DOORBELL_sDMA_ENGINE0 : AMDGPU_DOORBELL_sDMA_ENGINE1;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] drm/amdgpu: Temparary disable the sdma use pollmem feature for sriov.
[not found] ` <ea823ba5-5bf5-8ef2-40eb-bf763e9300f8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-01-22 1:55 ` Deng, Emily
0 siblings, 0 replies; 6+ messages in thread
From: Deng, Emily @ 2018-01-22 1:55 UTC (permalink / raw)
To: Koenig, Christian,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Hi Christian,
Thanks your comment, please ignore this patch. Will find out the root cause about why the pollmem doesn't work.
Best Wishes,
Emily Deng
> -----Original Message-----
> From: Christian König [mailto:ckoenig.leichtzumerken@gmail.com]
> Sent: Friday, January 19, 2018 6:22 PM
> To: Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/amdgpu: Temparary disable the sdma use pollmem
> feature for sriov.
>
> Am 19.01.2018 um 11:14 schrieb Emily Deng:
> > It still has some serious issues(guest driver reload fail, etc), when
> > use pollmem feature for sdma3.
> >
> > Signed-off-by: Emily Deng <Emily.Deng@amd.com>
> > ---
> > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> > b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> > index 3e22ae4..0f8f614 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> > @@ -1209,7 +1209,7 @@ static int sdma_v3_0_sw_init(void *handle)
> > for (i = 0; i < adev->sdma.num_instances; i++) {
> > ring = &adev->sdma.instance[i].ring;
> > ring->ring_obj = NULL;
> > - if (!amdgpu_sriov_vf(adev)) {
> > + if (1) {
>
> That needs a comment why we have it and I suggest writing this as:
>
> /* Disabled for now because... */
> if (true /* !amdgpu_sriov_vf(adev) */)
>
> Regards,
> Christian.
>
> > ring->use_doorbell = true;
> > ring->doorbell_index = (i == 0) ?
> > AMDGPU_DOORBELL_sDMA_ENGINE0 :
> AMDGPU_DOORBELL_sDMA_ENGINE1;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-22 1:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-19 10:14 [PATCH] drm/amdgpu: Temparary disable the sdma use pollmem feature for sriov Emily Deng
[not found] ` <1516356864-2622-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org>
2018-01-19 10:22 ` Christian König
[not found] ` <ea823ba5-5bf5-8ef2-40eb-bf763e9300f8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-22 1:55 ` Deng, Emily
-- strict thread matches above, loose matches on Subject: below --
2018-01-19 10:15 Emily Deng
2018-01-19 10:18 Emily Deng
2018-01-19 10:20 Emily Deng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox