From: "Christian König" <christian.koenig@amd.com>
To: Guchun Chen <guchun.chen@amd.com>,
amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com,
hawking.zhang@amd.com, bob.zhou@amd.com
Subject: Re: [PATCH] drm/amdgpu: keep irq count in amdgpu_irq_disable_all
Date: Thu, 25 May 2023 15:52:17 +0200 [thread overview]
Message-ID: <ead4f56c-3feb-518e-e37b-e9895b962264@amd.com> (raw)
In-Reply-To: <20230525092819.2471715-1-guchun.chen@amd.com>
Am 25.05.23 um 11:28 schrieb Guchun Chen:
> This can clean up all irq warnings because of unbalanced
> amdgpu_irq_get/put when unplugging/unbind device, and leave
> irq count decrease in each ip fini function.
>
> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> index 00f2106c17b9..f90920fbd340 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> @@ -140,7 +140,6 @@ void amdgpu_irq_disable_all(struct amdgpu_device *adev)
> continue;
>
> for (k = 0; k < src->num_types; ++k) {
> - atomic_set(&src->enabled_types[k], 0);
> r = src->funcs->set(adev, src, k,
> AMDGPU_IRQ_STATE_DISABLE);
> if (r)
prev parent reply other threads:[~2023-05-25 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 9:28 [PATCH] drm/amdgpu: keep irq count in amdgpu_irq_disable_all Guchun Chen
2023-05-25 13:52 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ead4f56c-3feb-518e-e37b-e9895b962264@amd.com \
--to=christian.koenig@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bob.zhou@amd.com \
--cc=guchun.chen@amd.com \
--cc=hawking.zhang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox