* [PATCH] drm/amdgpu: keep irq count in amdgpu_irq_disable_all
@ 2023-05-25 9:28 Guchun Chen
2023-05-25 13:52 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Guchun Chen @ 2023-05-25 9:28 UTC (permalink / raw)
To: amd-gfx, alexander.deucher, hawking.zhang, christian.koenig,
bob.zhou
Cc: Guchun Chen
This can clean up all irq warnings because of unbalanced
amdgpu_irq_get/put when unplugging/unbind device, and leave
irq count decrease in each ip fini function.
Signed-off-by: Guchun Chen <guchun.chen@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
index 00f2106c17b9..f90920fbd340 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
@@ -140,7 +140,6 @@ void amdgpu_irq_disable_all(struct amdgpu_device *adev)
continue;
for (k = 0; k < src->num_types; ++k) {
- atomic_set(&src->enabled_types[k], 0);
r = src->funcs->set(adev, src, k,
AMDGPU_IRQ_STATE_DISABLE);
if (r)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdgpu: keep irq count in amdgpu_irq_disable_all
2023-05-25 9:28 [PATCH] drm/amdgpu: keep irq count in amdgpu_irq_disable_all Guchun Chen
@ 2023-05-25 13:52 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2023-05-25 13:52 UTC (permalink / raw)
To: Guchun Chen, amd-gfx, alexander.deucher, hawking.zhang, bob.zhou
Am 25.05.23 um 11:28 schrieb Guchun Chen:
> This can clean up all irq warnings because of unbalanced
> amdgpu_irq_get/put when unplugging/unbind device, and leave
> irq count decrease in each ip fini function.
>
> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> index 00f2106c17b9..f90920fbd340 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> @@ -140,7 +140,6 @@ void amdgpu_irq_disable_all(struct amdgpu_device *adev)
> continue;
>
> for (k = 0; k < src->num_types; ++k) {
> - atomic_set(&src->enabled_types[k], 0);
> r = src->funcs->set(adev, src, k,
> AMDGPU_IRQ_STATE_DISABLE);
> if (r)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-25 13:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-25 9:28 [PATCH] drm/amdgpu: keep irq count in amdgpu_irq_disable_all Guchun Chen
2023-05-25 13:52 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox