AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Ma Jun <Jun.Ma2@amd.com>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	"Paneer Selvam, Arunpravin" <Arunpravin.PaneerSelvam@amd.com>
Subject: Re: [PATCH] drm/buddy: Fix drm buddy info output format
Date: Mon, 7 Aug 2023 08:47:13 +0200	[thread overview]
Message-ID: <ed0b3a5c-9e81-6fee-aba1-5d1c9ca89130@amd.com> (raw)
In-Reply-To: <20230804065647.4096957-1-Jun.Ma2@amd.com>

Am 04.08.23 um 08:56 schrieb Ma Jun:
> [1] Change pages to blocks to avoid confusion.
> [2] Fix output format to align the output info.
>
> Signed-off-by: Ma Jun <Jun.Ma2@amd.com>

Of hand looks good to me, but Arun should probably judge.

Christian.

> ---
>   drivers/gpu/drm/drm_buddy.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c
> index 3d1f50f481cf..ef3dd15c334a 100644
> --- a/drivers/gpu/drm/drm_buddy.c
> +++ b/drivers/gpu/drm/drm_buddy.c
> @@ -781,15 +781,15 @@ void drm_buddy_print(struct drm_buddy *mm, struct drm_printer *p)
>   			count++;
>   		}
>   
> -		drm_printf(p, "order-%d ", order);
> +		drm_printf(p, "order-%2d ", order);
>   
>   		free = count * (mm->chunk_size << order);
>   		if (free < SZ_1M)
> -			drm_printf(p, "free: %lluKiB", free >> 10);
> +			drm_printf(p, "free: %8llu KiB", free >> 10);
>   		else
> -			drm_printf(p, "free: %lluMiB", free >> 20);
> +			drm_printf(p, "free: %8llu MiB", free >> 20);
>   
> -		drm_printf(p, ", pages: %llu\n", count);
> +		drm_printf(p, ", blocks: %llu\n", count);
>   	}
>   }
>   EXPORT_SYMBOL(drm_buddy_print);


  reply	other threads:[~2023-08-07  6:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04  6:56 [PATCH] drm/buddy: Fix drm buddy info output format Ma Jun
2023-08-07  6:47 ` Christian König [this message]
2023-08-07 12:46   ` Arunpravin Paneer Selvam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed0b3a5c-9e81-6fee-aba1-5d1c9ca89130@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Arunpravin.PaneerSelvam@amd.com \
    --cc=Jun.Ma2@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox