Re: [PATCH] drm/buddy: Fix drm buddy info output format

[Arunpravin Paneer Selvam <arunpravin.paneerselvam@amd.com>]

[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]

looks good to me as well.

Reviewed-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>

On 8/7/2023 12:17 PM, Christian König wrote:
> Am 04.08.23 um 08:56 schrieb Ma Jun:
>> [1] Change pages to blocks to avoid confusion.
>> [2] Fix output format to align the output info.
>>
>> Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
>
> Of hand looks good to me, but Arun should probably judge.
>
> Christian.
>
>> ---
>>   drivers/gpu/drm/drm_buddy.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c
>> index 3d1f50f481cf..ef3dd15c334a 100644
>> --- a/drivers/gpu/drm/drm_buddy.c
>> +++ b/drivers/gpu/drm/drm_buddy.c
>> @@ -781,15 +781,15 @@ void drm_buddy_print(struct drm_buddy *mm, 
>> struct drm_printer *p)
>>               count++;
>>           }
>>   -        drm_printf(p, "order-%d ", order);
>> +        drm_printf(p, "order-%2d ", order);
>>             free = count * (mm->chunk_size << order);
>>           if (free < SZ_1M)
>> -            drm_printf(p, "free: %lluKiB", free >> 10);
>> +            drm_printf(p, "free: %8llu KiB", free >> 10);
>>           else
>> -            drm_printf(p, "free: %lluMiB", free >> 20);
>> +            drm_printf(p, "free: %8llu MiB", free >> 20);
>>   -        drm_printf(p, ", pages: %llu\n", count);
>> +        drm_printf(p, ", blocks: %llu\n", count);
>>       }
>>   }
>>   EXPORT_SYMBOL(drm_buddy_print);
>

[-- Attachment #2: Type: text/html, Size: 3413 bytes --]