* [PATCH] drm/buddy: Fix drm buddy info output format
@ 2023-08-04 6:56 Ma Jun
2023-08-07 6:47 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Ma Jun @ 2023-08-04 6:56 UTC (permalink / raw)
To: amd-gfx, dri-devel, christian.koenig; +Cc: Ma Jun
[1] Change pages to blocks to avoid confusion.
[2] Fix output format to align the output info.
Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
---
drivers/gpu/drm/drm_buddy.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c
index 3d1f50f481cf..ef3dd15c334a 100644
--- a/drivers/gpu/drm/drm_buddy.c
+++ b/drivers/gpu/drm/drm_buddy.c
@@ -781,15 +781,15 @@ void drm_buddy_print(struct drm_buddy *mm, struct drm_printer *p)
count++;
}
- drm_printf(p, "order-%d ", order);
+ drm_printf(p, "order-%2d ", order);
free = count * (mm->chunk_size << order);
if (free < SZ_1M)
- drm_printf(p, "free: %lluKiB", free >> 10);
+ drm_printf(p, "free: %8llu KiB", free >> 10);
else
- drm_printf(p, "free: %lluMiB", free >> 20);
+ drm_printf(p, "free: %8llu MiB", free >> 20);
- drm_printf(p, ", pages: %llu\n", count);
+ drm_printf(p, ", blocks: %llu\n", count);
}
}
EXPORT_SYMBOL(drm_buddy_print);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/buddy: Fix drm buddy info output format
2023-08-04 6:56 [PATCH] drm/buddy: Fix drm buddy info output format Ma Jun
@ 2023-08-07 6:47 ` Christian König
2023-08-07 12:46 ` Arunpravin Paneer Selvam
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2023-08-07 6:47 UTC (permalink / raw)
To: Ma Jun, amd-gfx, dri-devel, Paneer Selvam, Arunpravin
Am 04.08.23 um 08:56 schrieb Ma Jun:
> [1] Change pages to blocks to avoid confusion.
> [2] Fix output format to align the output info.
>
> Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
Of hand looks good to me, but Arun should probably judge.
Christian.
> ---
> drivers/gpu/drm/drm_buddy.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c
> index 3d1f50f481cf..ef3dd15c334a 100644
> --- a/drivers/gpu/drm/drm_buddy.c
> +++ b/drivers/gpu/drm/drm_buddy.c
> @@ -781,15 +781,15 @@ void drm_buddy_print(struct drm_buddy *mm, struct drm_printer *p)
> count++;
> }
>
> - drm_printf(p, "order-%d ", order);
> + drm_printf(p, "order-%2d ", order);
>
> free = count * (mm->chunk_size << order);
> if (free < SZ_1M)
> - drm_printf(p, "free: %lluKiB", free >> 10);
> + drm_printf(p, "free: %8llu KiB", free >> 10);
> else
> - drm_printf(p, "free: %lluMiB", free >> 20);
> + drm_printf(p, "free: %8llu MiB", free >> 20);
>
> - drm_printf(p, ", pages: %llu\n", count);
> + drm_printf(p, ", blocks: %llu\n", count);
> }
> }
> EXPORT_SYMBOL(drm_buddy_print);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/buddy: Fix drm buddy info output format
2023-08-07 6:47 ` Christian König
@ 2023-08-07 12:46 ` Arunpravin Paneer Selvam
0 siblings, 0 replies; 3+ messages in thread
From: Arunpravin Paneer Selvam @ 2023-08-07 12:46 UTC (permalink / raw)
To: Christian König, Ma Jun, amd-gfx, dri-devel
[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]
looks good to me as well.
Reviewed-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
On 8/7/2023 12:17 PM, Christian König wrote:
> Am 04.08.23 um 08:56 schrieb Ma Jun:
>> [1] Change pages to blocks to avoid confusion.
>> [2] Fix output format to align the output info.
>>
>> Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
>
> Of hand looks good to me, but Arun should probably judge.
>
> Christian.
>
>> ---
>> drivers/gpu/drm/drm_buddy.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c
>> index 3d1f50f481cf..ef3dd15c334a 100644
>> --- a/drivers/gpu/drm/drm_buddy.c
>> +++ b/drivers/gpu/drm/drm_buddy.c
>> @@ -781,15 +781,15 @@ void drm_buddy_print(struct drm_buddy *mm,
>> struct drm_printer *p)
>> count++;
>> }
>> - drm_printf(p, "order-%d ", order);
>> + drm_printf(p, "order-%2d ", order);
>> free = count * (mm->chunk_size << order);
>> if (free < SZ_1M)
>> - drm_printf(p, "free: %lluKiB", free >> 10);
>> + drm_printf(p, "free: %8llu KiB", free >> 10);
>> else
>> - drm_printf(p, "free: %lluMiB", free >> 20);
>> + drm_printf(p, "free: %8llu MiB", free >> 20);
>> - drm_printf(p, ", pages: %llu\n", count);
>> + drm_printf(p, ", blocks: %llu\n", count);
>> }
>> }
>> EXPORT_SYMBOL(drm_buddy_print);
>
[-- Attachment #2: Type: text/html, Size: 3413 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-07 12:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-04 6:56 [PATCH] drm/buddy: Fix drm buddy info output format Ma Jun
2023-08-07 6:47 ` Christian König
2023-08-07 12:46 ` Arunpravin Paneer Selvam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox