[PATCH v2] drm/amd/display: add proper error message for vblank init

[PATCH v2] drm/amd/display: add proper error message for vblank init

[Saleemkhan Jamadar]

v1 - DRM_ERROR to dev_err (Mario)

Update message to identifiy the vblank initialization fail case

Signed-off-by: Saleemkhan Jamadar <saleemkhan.jamadar@amd.com>
Reviewed-by: Rodrigo Siqueira <siqueira@igalia.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 8dd9bf58eac5..ecc6d48a2585 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -2217,8 +2217,8 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
 	adev_to_drm(adev)->mode_config.cursor_height = adev->dm.dc->caps.max_cursor_size;
 
 	if (drm_vblank_init(adev_to_drm(adev), adev->dm.display_indexes_num)) {
-		DRM_ERROR(
-		"amdgpu: failed to initialize sw for display support.\n");
+		dev_err(adev->dev,
+		"amdgpu: failed to initialize vblank sw for display support.\n");
 		goto error;
 	}
 
-- 
2.34.1

Re: [PATCH v2] drm/amd/display: add proper error message for vblank init

[Mario Limonciello]

On 3/21/2025 14:13, Saleemkhan Jamadar wrote:
> v1 - DRM_ERROR to dev_err (Mario)
> 
> Update message to identifiy the vblank initialization fail case
> 
> Signed-off-by: Saleemkhan Jamadar <saleemkhan.jamadar@amd.com>
> Reviewed-by: Rodrigo Siqueira <siqueira@igalia.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 8dd9bf58eac5..ecc6d48a2585 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -2217,8 +2217,8 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
>   	adev_to_drm(adev)->mode_config.cursor_height = adev->dm.dc->caps.max_cursor_size;
>   
>   	if (drm_vblank_init(adev_to_drm(adev), adev->dm.display_indexes_num)) {
> -		DRM_ERROR(
> -		"amdgpu: failed to initialize sw for display support.\n");
> +		dev_err(adev->dev,
> +		"amdgpu: failed to initialize vblank sw for display support.\n");
>   		goto error;
>   	}
>   

FYI - I had suggested drm_err() not dev_err().

[PATCH v2] drm/amd/display: add proper error message for vblank init

[Saleemkhan Jamadar]

Hi Mario,

Made the suggested change.

Regards,
Saleem

--------------2.34.1
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit


v1 - DRM_ERROR to drm_err (Mario)

Update message to identifiy the vblank initialization fail case

Signed-off-by: Saleemkhan Jamadar <saleemkhan.jamadar@amd.com>
Reviewed-by: Rodrigo Siqueira <siqueira@igalia.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


--------------2.34.1
Content-Type: text/x-patch; name="v2-0001-drm-amd-display-add-proper-error-message-for-vbla.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline; filename="v2-0001-drm-amd-display-add-proper-error-message-for-vbla.patch"

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 8dd9bf58eac5..1d3585149b0e 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -2217,8 +2217,8 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
 	adev_to_drm(adev)->mode_config.cursor_height = adev->dm.dc->caps.max_cursor_size;
 
 	if (drm_vblank_init(adev_to_drm(adev), adev->dm.display_indexes_num)) {
-		DRM_ERROR(
-		"amdgpu: failed to initialize sw for display support.\n");
+		drm_err(adev_to_drm(adev),
+		"amdgpu: failed to initialize vblank sw for display support.\n");
 		goto error;
 	}
 

--------------2.34.1--

Re: [PATCH v2] drm/amd/display: add proper error message for vblank init

[Mario Limonciello]

On 3/24/2025 13:45, Saleemkhan Jamadar wrote:
> Hi Mario,
> 
> Made the suggested change.
> 
> Regards,
> Saleem

I'm not sure what happened to the below text (maybe email client failure?).

But in any case the change looks good to me now.  You can add:
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

When committing it.

Thanks,

> 
> --------------2.34.1
> Content-Type: text/plain; charset=UTF-8; format=fixed
> Content-Transfer-Encoding: 8bit
> 
> 
> v1 - DRM_ERROR to drm_err (Mario)
> 
> Update message to identifiy the vblank initialization fail case
> 
> Signed-off-by: Saleemkhan Jamadar <saleemkhan.jamadar@amd.com>
> Reviewed-by: Rodrigo Siqueira <siqueira@igalia.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> 
> --------------2.34.1
> Content-Type: text/x-patch; name="v2-0001-drm-amd-display-add-proper-error-message-for-vbla.patch"
> Content-Transfer-Encoding: 8bit
> Content-Disposition: inline; filename="v2-0001-drm-amd-display-add-proper-error-message-for-vbla.patch"
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 8dd9bf58eac5..1d3585149b0e 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -2217,8 +2217,8 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
>   	adev_to_drm(adev)->mode_config.cursor_height = adev->dm.dc->caps.max_cursor_size;
>   
>   	if (drm_vblank_init(adev_to_drm(adev), adev->dm.display_indexes_num)) {
> -		DRM_ERROR(
> -		"amdgpu: failed to initialize sw for display support.\n");
> +		drm_err(adev_to_drm(adev),
> +		"amdgpu: failed to initialize vblank sw for display support.\n");
>   		goto error;
>   	}
>   
> 
> --------------2.34.1--
> 
>