From: Janne Grunau <j@jannau.net>
To: Nick Chan <towinchenmi@gmail.com>
Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: spi: apple,spi: Add binding for Apple SPI controllers
Date: Sat, 2 Nov 2024 09:36:08 +0100 [thread overview]
Message-ID: <20241102083608.GA308136@robin.jannau.net> (raw)
In-Reply-To: <46b31874-9fe2-4534-9777-816765a265b1@gmail.com>
On Sat, Nov 02, 2024 at 10:36:56AM +0800, Nick Chan wrote:
>
>
> On 2/11/2024 03:26, Janne Grunau via B4 Relay wrote:
>
> [...]
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - apple,t8103-spi
> > + - apple,t8112-spi
> > + - apple,t6000-spi
> > + - const: apple,spi
> Apple A7-A11 SoCs seems to use a Samsung SPI block, so apple,spi is too
> generic. Fallback to something like apple,t8103-spi instead.
Have you looked at it? This one still seems to be somehow Samsung
related. See the previous discussion at
https://lore.kernel.org/linux-devicetree/d87ae109-4b58-7465-b16e-3bf7c9d60f1f@marcan.st/
Even the A7-A11 SPI controllers are not compatible "apple,spi" doesn't
prevent us from using something like "apple,s5l-spi" for those.
Janne
next prev parent reply other threads:[~2024-11-02 8:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 19:26 [PATCH v3 0/3] Apple SPI controller driver Janne Grunau via B4 Relay
2024-11-01 19:26 ` [PATCH v3 1/3] dt-bindings: spi: apple,spi: Add binding for Apple SPI controllers Janne Grunau via B4 Relay
2024-11-02 2:36 ` Nick Chan
2024-11-02 8:36 ` Janne Grunau [this message]
2024-11-02 8:39 ` Mark Kettenis
2024-11-02 13:15 ` Nick Chan
2024-11-04 18:56 ` Conor Dooley
2024-11-05 7:46 ` Janne Grunau
2024-11-01 19:26 ` [PATCH v3 2/3] spi: apple: Add driver for Apple SPI controller Janne Grunau via B4 Relay
2024-11-04 19:16 ` Christophe JAILLET
2024-11-05 7:50 ` Janne Grunau
2024-11-01 19:26 ` [PATCH v3 3/3] MAINTAINERS: Add apple-spi driver & binding files Janne Grunau via B4 Relay
2024-11-02 13:11 ` [PATCH v3 0/3] Apple SPI controller driver Krzysztof Kozlowski
2024-11-05 7:44 ` Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241102083608.GA308136@robin.jannau.net \
--to=j@jannau.net \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh@kernel.org \
--cc=sven@svenpeter.dev \
--cc=towinchenmi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox