From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Nick Chan <towinchenmi@gmail.com>
Cc: j@jannau.net, marcan@marcan.st, sven@svenpeter.dev,
alyssa@rosenzweig.io, broonie@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: spi: apple,spi: Add binding for Apple SPI controllers
Date: Sat, 02 Nov 2024 09:39:32 +0100 [thread overview]
Message-ID: <87wmhm3u7v.fsf@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <46b31874-9fe2-4534-9777-816765a265b1@gmail.com> (message from Nick Chan on Sat, 2 Nov 2024 10:36:56 +0800)
> Date: Sat, 2 Nov 2024 10:36:56 +0800
> Content-Language: en-MW
>
> On 2/11/2024 03:26, Janne Grunau via B4 Relay wrote:
>
> [...]
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - apple,t8103-spi
> > + - apple,t8112-spi
> > + - apple,t6000-spi
> > + - const: apple,spi
> Apple A7-A11 SoCs seems to use a Samsung SPI block, so apple,spi is too
> generic. Fallback to something like apple,t8103-spi instead.
Well, if that is a Samsung SPI block it probably should have a
"generic" compatible that starts with "samsung,". The M1/M2
controllers have a different SPI block (presumably) designed by Apple
themselves. So I think it is (still) appropriate that that one is
"apple,spi".
Also, (upstream) U-Boot already uses the "apple,spi" compatible. So
changing it for purity sake just causes pain.
next prev parent reply other threads:[~2024-11-02 8:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 19:26 [PATCH v3 0/3] Apple SPI controller driver Janne Grunau via B4 Relay
2024-11-01 19:26 ` [PATCH v3 1/3] dt-bindings: spi: apple,spi: Add binding for Apple SPI controllers Janne Grunau via B4 Relay
2024-11-02 2:36 ` Nick Chan
2024-11-02 8:36 ` Janne Grunau
2024-11-02 8:39 ` Mark Kettenis [this message]
2024-11-02 13:15 ` Nick Chan
2024-11-04 18:56 ` Conor Dooley
2024-11-05 7:46 ` Janne Grunau
2024-11-01 19:26 ` [PATCH v3 2/3] spi: apple: Add driver for Apple SPI controller Janne Grunau via B4 Relay
2024-11-04 19:16 ` Christophe JAILLET
2024-11-05 7:50 ` Janne Grunau
2024-11-01 19:26 ` [PATCH v3 3/3] MAINTAINERS: Add apple-spi driver & binding files Janne Grunau via B4 Relay
2024-11-02 13:11 ` [PATCH v3 0/3] Apple SPI controller driver Krzysztof Kozlowski
2024-11-05 7:44 ` Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmhm3u7v.fsf@bloch.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh@kernel.org \
--cc=sven@svenpeter.dev \
--cc=towinchenmi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox