Linux on Apple ARM platform development
 help / color / mirror / Atom feed
From: "Janne Grunau" <j@jannau.net>
To: "Aditya Garg" <gargaditya08@live.com>,
	"Hector Martin" <marcan@marcan.st>,
	"Sven Peter" <sven@svenpeter.dev>,
	"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
	"marcel@holtmann.org" <marcel@holtmann.org>,
	"johan.hedberg@gmail.com" <johan.hedberg@gmail.com>,
	"luiz.dentz@gmail.com" <luiz.dentz@gmail.com>
Cc: "Orlando Chamberlain" <orlandoch.dev@gmail.com>,
	"Kerem Karabay" <kekrby@gmail.com>,
	"Aun-Ali Zaidi" <admin@kodeit.net>,
	"Asahi Linux" <asahi@lists.linux.dev>,
	LKML <linux-kernel@vger.kernel.org>,
	"linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>
Subject: Re: [REGRESSION] Bluetooth is not working on Macs with BCM4377 chip starting from kernel 6.5
Date: Tue, 14 Nov 2023 09:35:27 +0100	[thread overview]
Message-ID: <9308033b-971f-4cbf-9443-d41a3f09ac61@app.fastmail.com> (raw)
In-Reply-To: <22582194-DE99-45E5-ABEE-C1C7900DA523@live.com>

Hej,

On Mon, Nov 13, 2023, at 21:57, Aditya Garg wrote:
> Starting from kernel 6.5, a regression in the kernel is causing 
> Bluetooth to not work on T2 Macs with BCM4377 chip.
>
> Journalctl of kernel 6.4.8 which has Bluetooth working is given here: 
> https://pastebin.com/u9U3kbFJ
>
> Journalctl of kernel 6.5.2, which has Bluetooth broken is given here: 
> https://pastebin.com/aVHNFMRs
>
> Also, the bug hasn’t been fixed even in 6.6.1, as reported by users.

There could be a possible regression in kernel 6.4 and later affecting Bluetooth low energy on bcm4377 devices specifically.  288c90224eec ("Bluetooth: Enable all supported LE PHY by default") broke BLE connections on bcm4378 and bcm4387. I did not find any reports about broken BLE on bcm4377 so I marked only bcm4378 and bcm4387 as broken with Coded Phy in 41e9cdea9c4a ("Bluetooth: hci_bcm4377: Mark bcm4378/bcm4387 as BROKEN_LE_CODED")

If  BLE devices like Logitech keyboards/mice are affected (mostly during pairing) it would be worth testing the change below (against v6.7-rc or stable releases):

diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm4377.c
index a61757835695..bc8398cde3c3 100644
--- a/drivers/bluetooth/hci_bcm4377.c
+++ b/drivers/bluetooth/hci_bcm4377.c
@@ -2453,6 +2453,7 @@ static const struct bcm4377_hw bcm4377_hw_variants[] = {
                .bar0_window2 = 0x1810c000,
                .disable_aspm = true,
                .broken_ext_scan = true,
+               .broken_le_coded = true,
                .send_ptb = bcm4377_send_ptb,
        },
 
This  should affect 6.4.8 as well so might be unrelated to the reported issue.

Janne

  parent reply	other threads:[~2023-11-14  8:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-13 20:57 [REGRESSION] Bluetooth is not working on Macs with BCM4377 chip starting from kernel 6.5 Aditya Garg
2023-11-13 23:31 ` Bagas Sanjaya
2023-11-14  6:23   ` Aditya Garg
2023-11-14  6:59     ` Hector Martin
2023-11-14  7:58       ` Hector Martin
2023-11-14  8:18         ` Aditya Garg
2023-11-14  9:03         ` Aditya Garg
2023-11-14  9:44           ` Hector Martin
2023-11-14 10:05             ` Aditya Garg
2023-11-18 19:31             ` Aditya Garg
2023-11-20 11:07               ` Hector Martin
2023-11-21 11:42                 ` Aditya Garg
2023-11-21 12:16                   ` Hector Martin
2023-11-14  8:35 ` Janne Grunau [this message]
2023-12-24 18:04 ` Felix Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9308033b-971f-4cbf-9443-d41a3f09ac61@app.fastmail.com \
    --to=j@jannau.net \
    --cc=admin@kodeit.net \
    --cc=alyssa@rosenzweig.io \
    --cc=asahi@lists.linux.dev \
    --cc=gargaditya08@live.com \
    --cc=johan.hedberg@gmail.com \
    --cc=kekrby@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcan@marcan.st \
    --cc=marcel@holtmann.org \
    --cc=orlandoch.dev@gmail.com \
    --cc=sven@svenpeter.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox