Re: 9984 VHT

[Sebastian Gottschall <s.gottschall@dd-wrt.com>]

this code here has been used

         if (arg->mode == MODE_11AC_VHT160)  {
                 if (arg->freq < arg->band_center_freq1)
                         ch->band_center_freq1 = __cpu_to_le32(arg->freq 
+ 40);
                 else
                         ch->band_center_freq1 = __cpu_to_le32(arg->freq 
- 40);
                 ch->band_center_freq2 = 
__cpu_to_le32(arg->band_center_freq1);
         }


Am 02.02.2017 um 21:50 schrieb Ben Greear:
> On 02/02/2017 12:45 PM, Sebastian Gottschall wrote:
>
>>>> +       if (arg->mode == MODE_11AC_VHT160)  {
>>>> +               ch->band_center_freq1 = __cpu_to_le32(arg->freq);
>>>> +               ch->band_center_freq2 = 
>>>> __cpu_to_le32(arg->band_center_freq1);
>>>> +       }
>>>
>>> No, I don't think so.  freq1 should be freq + 40 if freq < 
>>> center-freq, otherwise
>>> should be freq - 40.
>> doesnt sound very logic since 80+80 mode doesnt require that voodoo 
>> too since it would require another addition field. but i will try it 
>> it right now
>
> The firmware change looks pretty lame to me...it was easy for me to 
> make my FW backwards compat
> to the old way of just passing in the mhz and the freq1 160mhz 
> center-freq, so really I do not know why
> the FW was changed.
>
> I am testing my FW fixes now...
>
> Thanks,
> Ben
>


-- 
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz:  Berliner Ring 101, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall@dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k