From: Ben Greear <greearb@candelatech.com>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>,
"Valo, Kalle" <kvalo@qca.qualcomm.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: 9984 VHT
Date: Thu, 2 Feb 2017 12:50:35 -0800 [thread overview]
Message-ID: <fb1ebe0c-c6b1-ef54-64bb-8a4d4fe3a399@candelatech.com> (raw)
In-Reply-To: <e3e5492e-1a58-ff2c-bf7c-016a2f19a79b@dd-wrt.com>
On 02/02/2017 12:45 PM, Sebastian Gottschall wrote:
>>> + if (arg->mode == MODE_11AC_VHT160) {
>>> + ch->band_center_freq1 = __cpu_to_le32(arg->freq);
>>> + ch->band_center_freq2 = __cpu_to_le32(arg->band_center_freq1);
>>> + }
>>
>> No, I don't think so. freq1 should be freq + 40 if freq < center-freq, otherwise
>> should be freq - 40.
> doesnt sound very logic since 80+80 mode doesnt require that voodoo too since it would require another addition field. but i will try it it right now
The firmware change looks pretty lame to me...it was easy for me to make my FW backwards compat
to the old way of just passing in the mhz and the freq1 160mhz center-freq, so really I do not know why
the FW was changed.
I am testing my FW fixes now...
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-02-02 20:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 23:11 QCA988X firmware pull-push support Sergey Ryazanov
[not found] ` <CAJ-Vmo=yD7Ct5LFXBO3qNhKsNco91VXMmZOYeBaAuw+DFGq=RQ@mail.gmail.com>
2017-01-30 1:20 ` Sergey Ryazanov
2017-01-30 2:50 ` Adrian Chadd
2017-01-30 8:13 ` Valo, Kalle
2017-01-30 10:28 ` 9984 VHT Sebastian Gottschall
2017-02-01 16:48 ` Ben Greear
2017-02-01 18:45 ` Sebastian Gottschall
2017-02-02 16:18 ` Ben Greear
2017-02-02 18:24 ` Ben Greear
2017-02-02 18:42 ` Sebastian Gottschall
2017-02-02 19:05 ` Ben Greear
2017-02-02 19:08 ` Sebastian Gottschall
2017-02-02 19:18 ` Ben Greear
2017-02-02 19:29 ` Sebastian Gottschall
2017-02-02 19:32 ` Ben Greear
2017-02-02 20:28 ` Sebastian Gottschall
2017-02-02 20:37 ` Ben Greear
2017-02-02 20:45 ` Sebastian Gottschall
2017-02-02 20:50 ` Ben Greear [this message]
2017-02-02 21:01 ` Sebastian Gottschall
2017-02-02 21:04 ` Sebastian Gottschall
2017-02-07 12:14 ` Valo, Kalle
2017-02-07 12:39 ` Sebastian Gottschall
2017-02-10 6:50 ` Valo, Kalle
[not found] ` <c894f9ae-068a-eac3-16e6-c1ada4da22b9@dd-wrt.com>
2017-02-14 10:30 ` Valo, Kalle
2017-02-14 15:21 ` Sebastian Gottschall
2017-02-16 16:20 ` Adrian Chadd
2017-02-16 16:34 ` Sebastian Gottschall
2017-02-17 5:42 ` Adrian Chadd
2017-02-20 15:40 ` Valo, Kalle
2017-02-01 8:21 ` QCA988X firmware pull-push support Sergey Ryazanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb1ebe0c-c6b1-ef54-64bb-8a4d4fe3a399@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=s.gottschall@dd-wrt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox