From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: dont call csa_finish more than once
Date: Fri, 21 Mar 2014 15:17:20 +0100 [thread overview]
Message-ID: <1395411440.4164.15.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1395410520-26939-1-git-send-email-michal.kazior@tieto.com> (sfid-20140321_150948_706832_25F8B34B)
On Fri, 2014-03-21 at 15:02 +0100, Michal Kazior wrote:
> Driver is supposed to call it only once for each
> scheduled channel_switch_beacon().
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> ---
> This is required for multi-vif csa but since that
> isn't merged yet I'm not including any specifics
> in the commit log itself.
>
> Preventing multiple ieee80211_csa_finish() calls
> sounds like a good idea in general to me.
Didn't we have this discussion on the hwsim patch before?
I'd argue that if all drivers must track this, then the mac80211 API is
defective.
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-03-21 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 14:02 [PATCH] ath10k: dont call csa_finish more than once Michal Kazior
2014-03-21 14:17 ` Johannes Berg [this message]
2014-03-21 14:58 ` Michal Kazior
2014-03-21 15:07 ` Johannes Berg
2014-03-24 6:37 ` Michal Kazior
2014-03-28 8:32 ` Johannes Berg
2014-03-25 8:00 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395411440.4164.15.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox