From: Joe Perches <joe@perches.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 0/4] ath10k: fix/cleanup fw stats
Date: Fri, 26 Sep 2014 07:14:21 -0700 [thread overview]
Message-ID: <1411740861.19443.6.camel@joe-AO725> (raw)
In-Reply-To: <CA+BoTQmJ-HprccxTO3UrX+NkhOMVt2i2X7p4k0b5bs6TVrKrpw@mail.gmail.com>
On Fri, 2014-09-26 at 13:14 +0200, Michal Kazior wrote:
> On 26 September 2014 13:06, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> > drivers/net/wireless/ath/ath10k/wmi.c:1513: WARNING: else is not generally useful after a break or return
> I'm aware of this one but the code looks nicer with the `else` to me though.
Yay Michal.
Always use your taste over any mindless style tool.
Ignore any checkpatch complaint you want.
btw: checkpatch shouldn't warn about this as of:
commit adefeef310ee8bd3923d41b67bc53c398bc53621
Author: Joe Perches <joe@perches.com>
Date: Fri Sep 26 10:19:29 2014 +1000
checkpatch: add exception to return then else test
Add an exception to the return before else warning
when the line following it is also a return like:
if (foo)
return bar;
else
return baz;
This form of a test then return is at least as readable as
if (foo)
return bar;
return baz;
so don't emit a warning on the first form.
Signed-off-by: Joe Perches <joe@perches.com>
Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Elshad Mustafayev <elshadimo@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-09-26 14:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 10:33 [PATCH 0/4] ath10k: fix/cleanup fw stats Michal Kazior
2014-09-25 10:33 ` [PATCH 1/4] ath10k: split wmi stats parsing Michal Kazior
2014-09-25 10:33 ` [PATCH 2/4] ath10k: rename fw_stats related stuff Michal Kazior
2014-09-25 10:33 ` [PATCH 3/4] ath10k: request fw_stats once on open Michal Kazior
2014-09-25 10:33 ` [PATCH 4/4] ath10k: fix fw stats processing Michal Kazior
2014-09-27 8:01 ` Kalle Valo
2014-09-29 7:16 ` Michal Kazior
2014-09-29 7:38 ` Kalle Valo
2014-09-26 11:06 ` [PATCH 0/4] ath10k: fix/cleanup fw stats Kalle Valo
2014-09-26 11:14 ` Michal Kazior
2014-09-26 14:14 ` Joe Perches [this message]
2014-09-29 11:32 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411740861.19443.6.camel@joe-AO725 \
--to=joe@perches.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox