From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 4/4] ath10k: fix fw stats processing
Date: Sat, 27 Sep 2014 11:01:23 +0300 [thread overview]
Message-ID: <8761g94hm4.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1411641230-18785-5-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 25 Sep 2014 12:33:50 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> If stat data exceeds wmi-htc buffer limits
> firmware splits it into many wmi stats update
> events which are delivered in a ping-pong fashion
> triggered by wmi stats request command.
>
> Since there's only an implicit start-of-data and
> no end-of-data indications the driver has to
> perform some trickery to get complete stat data.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
I folded the patch below in ath-next-next. Please check:
https://github.com/kvalo/ath/commit/7071112c5ddaff761cd7d9bb3110c3f3d2f83bb8
diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
index 0e6626282664..680d5088b6f3 100644
--- a/drivers/net/wireless/ath/ath10k/debug.c
+++ b/drivers/net/wireless/ath/ath10k/debug.c
@@ -343,7 +343,7 @@ void ath10k_debug_fw_stats_process(struct ath10k *ar, struct sk_buff *skb)
free:
/* In some cases lists have been spliced and cleared. Free up
- * resouruces if that is not the case.
+ * resources if that is not the case.
*/
ath10k_debug_fw_stats_pdevs_free(&stats.pdevs);
ath10k_debug_fw_stats_peers_free(&stats.peers);
@@ -536,7 +536,7 @@ static void ath10k_fw_stats_fill(struct ath10k *ar,
"MPDU errors (FCS, MIC, ENC)", pdev->mpdu_errs);
len += scnprintf(buf + len, buf_len - len, "\n");
- len += scnprintf(buf + len, buf_len - len, "%30s (%lu)\n",
+ len += scnprintf(buf + len, buf_len - len, "%30s (%zu)\n",
"ath10k PEER stats", num_peers);
len += scnprintf(buf + len, buf_len - len, "%30s\n\n",
"=================");
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-09-27 8:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 10:33 [PATCH 0/4] ath10k: fix/cleanup fw stats Michal Kazior
2014-09-25 10:33 ` [PATCH 1/4] ath10k: split wmi stats parsing Michal Kazior
2014-09-25 10:33 ` [PATCH 2/4] ath10k: rename fw_stats related stuff Michal Kazior
2014-09-25 10:33 ` [PATCH 3/4] ath10k: request fw_stats once on open Michal Kazior
2014-09-25 10:33 ` [PATCH 4/4] ath10k: fix fw stats processing Michal Kazior
2014-09-27 8:01 ` Kalle Valo [this message]
2014-09-29 7:16 ` Michal Kazior
2014-09-29 7:38 ` Kalle Valo
2014-09-26 11:06 ` [PATCH 0/4] ath10k: fix/cleanup fw stats Kalle Valo
2014-09-26 11:14 ` Michal Kazior
2014-09-26 14:14 ` Joe Perches
2014-09-29 11:32 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761g94hm4.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox