ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ath10k: Fix check for !THERMAL case
@ 2015-11-26 12:15 Mark Brown
  2015-11-27 16:54 ` kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2015-11-26 12:15 UTC (permalink / raw)
  To: Kalle Valo; +Cc: Mark Brown, linux-wireless, ath10k

When defining stubs for !THERMAL cases we currently check if CONFIG_THERMAL
is defined but this fails when the thermal code is built as a module in
which case CONFIG_THERMAL_MODULE is defined instead causing us to define
the stubs as well as building the actual ath10k thermal code which in turn
causes the build to fail on arm64 allmodconfig. Fix this by changing the
check in the header to use IS_ENABLED().

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/net/wireless/ath/ath10k/thermal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/thermal.h b/drivers/net/wireless/ath/ath10k/thermal.h
index b610ea5caae8..793eec160e65 100644
--- a/drivers/net/wireless/ath/ath10k/thermal.h
+++ b/drivers/net/wireless/ath/ath10k/thermal.h
@@ -36,7 +36,7 @@ struct ath10k_thermal {
 	int temperature;
 };
 
-#ifdef CONFIG_THERMAL
+#if IS_ENABLED(CONFIG_THERMAL)
 int ath10k_thermal_register(struct ath10k *ar);
 void ath10k_thermal_unregister(struct ath10k *ar);
 void ath10k_thermal_event_temperature(struct ath10k *ar, int temperature);
-- 
2.6.2


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ath10k: Fix check for !THERMAL case
  2015-11-26 12:15 [PATCH] ath10k: Fix check for !THERMAL case Mark Brown
@ 2015-11-27 16:54 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-11-27 16:54 UTC (permalink / raw)
  To: Mark Brown; +Cc: Kalle Valo, linux-wireless, kbuild-all, ath10k

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

Hi Mark,

[auto build test ERROR on net-next/master]
[also build test ERROR on v4.4-rc2]
[cannot apply to next-20151127]

url:    https://github.com/0day-ci/linux/commits/Mark-Brown/ath10k-Fix-check-for-THERMAL-case/20151126-201844
config: m68k-allmodconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All errors (new ones prefixed by >>):

>> ERROR: "ath10k_thermal_event_temperature" [drivers/net/wireless/ath/ath10k/ath10k_core.ko] undefined!
>> ERROR: "ath10k_thermal_set_throttling" [drivers/net/wireless/ath/ath10k/ath10k_core.ko] undefined!
>> ERROR: "ath10k_thermal_register" [drivers/net/wireless/ath/ath10k/ath10k_core.ko] undefined!
>> ERROR: "ath10k_thermal_unregister" [drivers/net/wireless/ath/ath10k/ath10k_core.ko] undefined!

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 34875 bytes --]

[-- Attachment #3: Type: text/plain, Size: 146 bytes --]

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-27 16:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-26 12:15 [PATCH] ath10k: Fix check for !THERMAL case Mark Brown
2015-11-27 16:54 ` kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox