From: Vincent Tremblay <vincent@vtremblay.dev>
Cc: ath10k@lists.infradead.org, vincent@vtremblay.dev
Subject: [PATCH v2] dt-bindings: ath10k: fix qcom,coexist-support documentation
Date: Fri, 30 Dec 2022 23:58:41 -0500 [thread overview]
Message-ID: <20221231045841.3381365-1-vincent@vtremblay.dev> (raw)
In-Reply-To: <20221231044752.3379895-1-vincent@vtremblay.dev>
The driver is reading the value using the function
"of_property_read_u8", which is expecting the data to be
represented on 8 bits.
By default, the value specified in the DT is saved using a 32 bits
format, which cause the driver to read "0" instead of "1".
To make the driver work properly, the DT should specify the right
data representation to use.
Signed-off-by: Vincent Tremblay <vincent@vtremblay.dev>
---
v2 changes:
- Remove unrelated changes
.../devicetree/bindings/net/wireless/qcom,ath10k.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
index b61c2d5a0ff7..4a66ceeb1e76 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
@@ -92,8 +92,8 @@ Optional properties:
- qcom,msa-fixed-perm: Boolean context flag to disable SCM call for statically
mapped msa region.
-- qcom,coexist-support : should contain eithr "0" or "1" to indicate coex
- support by the hardware.
+- qcom,coexist-support : should contain a 8 bits value representing either
+ "0" or "1" to indicate coex support by the hardware.
- qcom,coexist-gpio-pin : gpio pin number information to support coex
which will be used by wifi firmware.
@@ -176,7 +176,7 @@ wifi0: wifi@a000000 {
qcom,msi_addr = <0x0b006040>;
qcom,msi_base = <0x40>;
qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
- qcom,coexist-support = <1>;
+ qcom,coexist-support = /bits/ 8 <1>;
qcom,coexist-gpio-pin = <0x33>;
};
--
2.37.2
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2022-12-31 4:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-31 4:47 [PATCH] dt-bindings: ath10k: fix qcom,coexist-support documentation Vincent Tremblay
2022-12-31 4:58 ` Vincent Tremblay [this message]
2022-12-31 14:15 ` Vincent Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221231045841.3381365-1-vincent@vtremblay.dev \
--to=vincent@vtremblay.dev \
--cc=ath10k@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox