From: Sujith Manoharan <sujith@msujith.org>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [RFC] ath10k: Fix shared WEP
Date: Fri, 21 Nov 2014 16:27:30 +0530 [thread overview]
Message-ID: <21615.6810.716982.963365@gargle.gargle.HOWL> (raw)
In-Reply-To: <CA+BoTQk2fy024b5E=khSrzpUGzCL=jU_4wpxJ0AAyxmsFZuWhA@mail.gmail.com>
Michal Kazior wrote:
> Yes. Basically peer->keys[] should be protected by both conf_mutex and
> data_lock if you want to modify it. If you want to read it you need
> either one.
Ok.
> Thanks! Looks like the `cancel_work_sync(&arvif->wep_key_work);`
> should go _before_ `mutex_lock(&ar->conf_mutex);`.
>
> I'm busy with some stuff so feel free to send a patch :-)
I'll send a fix after this one. Thanks for the review !
Sujith
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-11-21 10:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 14:06 [RFC] ath10k: Fix shared WEP Sujith Manoharan
2014-11-21 9:03 ` Michal Kazior
2014-11-21 9:54 ` Sujith Manoharan
2014-11-21 10:14 ` Michal Kazior
2014-11-21 10:36 ` Sujith Manoharan
2014-11-21 10:40 ` Michal Kazior
2014-11-21 10:57 ` Sujith Manoharan [this message]
2014-11-21 17:05 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21615.6810.716982.963365@gargle.gargle.HOWL \
--to=sujith@msujith.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox