ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Sujith Manoharan <sujith@msujith.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [RFC] ath10k: Fix shared WEP
Date: Fri, 21 Nov 2014 19:05:41 +0200	[thread overview]
Message-ID: <87k32obi1m.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1416492382-18058-1-git-send-email-sujith@msujith.org> (Sujith Manoharan's message of "Thu, 20 Nov 2014 19:36:22 +0530")

Sujith Manoharan <sujith@msujith.org> writes:

> From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
>
> When static keys are used in shared WEP, when a
> station is associated, message 3 is sent with an
> encrypted payload. But, for subsequent
> authentications that are triggered without a
> deauth, the auth frame is decrypted by the HW. To
> handle this, check if the WEP keys have already
> been set for the peer and if so, mark the
> frame as decrypted.
>
> Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>

[...]

> +		if (peer_key) {
> +			ath10k_dbg(ar, ATH10K_DBG_MAC,
> +				   "wep key present for peer: %pM\n", addr);
> +			status->flag |= RX_FLAG_DECRYPTED;
> +		}
> +	}
> +
> +}

A checkpatch warning:

drivers/net/wireless/ath/ath10k/wmi.c:1141: CHECK: Blank lines aren't necessary before a close brace '}'

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

      parent reply	other threads:[~2014-11-21 17:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 14:06 [RFC] ath10k: Fix shared WEP Sujith Manoharan
2014-11-21  9:03 ` Michal Kazior
2014-11-21  9:54   ` Sujith Manoharan
2014-11-21 10:14     ` Michal Kazior
2014-11-21 10:36       ` Sujith Manoharan
2014-11-21 10:40         ` Michal Kazior
2014-11-21 10:57           ` Sujith Manoharan
2014-11-21 17:05 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k32obi1m.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sujith@msujith.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox