* Any idea why we cannot disable /b rates? @ 2015-02-24 17:43 Ben Greear 2015-02-24 19:44 ` Ben Greear 0 siblings, 1 reply; 7+ messages in thread From: Ben Greear @ 2015-02-24 17:43 UTC (permalink / raw) To: ath10k I'm going to start digging into the code, but in case someone already knows... I ran this command to try to disable any frames set at /b rates (AP is on channel 1). But, according to ath10k sniffer, beacons are still sent with 1Mbps rate. iw dev vap1 set bitrates legacy-2.4 12 mcs-2.4 Thanks, Ben -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Any idea why we cannot disable /b rates? 2015-02-24 17:43 Any idea why we cannot disable /b rates? Ben Greear @ 2015-02-24 19:44 ` Ben Greear 2015-02-25 2:45 ` Yeoh Chun-Yeow 0 siblings, 1 reply; 7+ messages in thread From: Ben Greear @ 2015-02-24 19:44 UTC (permalink / raw) To: ath10k Ok, so I found the problem. Appears that the firmware uses two different fixed rate-ctrl settings, one for non-data (bcast, mgt-frames, etc) and another for data frames. The non-data one was not being set when user configured fixed rates, so beacons went out at 1Mbps. I updated CT firmware (beta-14) to set both data and non-data to the same value when the driver specifies the rates... Seems to work...any idea if this is a bad idea in practice? Thanks, Ben On 02/24/2015 09:43 AM, Ben Greear wrote: > I'm going to start digging into the code, but in case someone already > knows... > > I ran this command to try to disable any frames set at /b rates (AP is on channel 1). > > But, according to ath10k sniffer, beacons are still sent with 1Mbps rate. > > iw dev vap1 set bitrates legacy-2.4 12 mcs-2.4 > > > Thanks, > Ben > -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Any idea why we cannot disable /b rates? 2015-02-24 19:44 ` Ben Greear @ 2015-02-25 2:45 ` Yeoh Chun-Yeow 2015-02-25 5:02 ` Ben Greear 0 siblings, 1 reply; 7+ messages in thread From: Yeoh Chun-Yeow @ 2015-02-25 2:45 UTC (permalink / raw) To: Ben Greear; +Cc: ath10k On Wed, Feb 25, 2015 at 3:44 AM, Ben Greear <greearb@candelatech.com> wrote: > Ok, so I found the problem. Appears that the firmware uses two different > fixed rate-ctrl settings, one for non-data (bcast, mgt-frames, etc) and another > for data frames. The non-data one was not being set when user configured > fixed rates, so beacons went out at 1Mbps. > > I updated CT firmware (beta-14) to set both data and non-data to the same > value when the driver specifies the rates... Seems to work...any idea > if this is a bad idea in practice? Rate control is applicable to unicast frame whether it is management/data. Broadcast/Multicast rate is required for management/data (usually the lowest transmission rate 5GHz is 6Mbps). So it is more sensible if we can configure the broadcast/multicast rate and also disable the rate control for unicast frame by using fixed rate. --- Chun-Yeow _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Any idea why we cannot disable /b rates? 2015-02-25 2:45 ` Yeoh Chun-Yeow @ 2015-02-25 5:02 ` Ben Greear 2015-02-25 10:30 ` Yeoh Chun-Yeow 0 siblings, 1 reply; 7+ messages in thread From: Ben Greear @ 2015-02-25 5:02 UTC (permalink / raw) To: Yeoh Chun-Yeow; +Cc: ath10k On 02/24/2015 06:45 PM, Yeoh Chun-Yeow wrote: > On Wed, Feb 25, 2015 at 3:44 AM, Ben Greear <greearb@candelatech.com> wrote: >> Ok, so I found the problem. Appears that the firmware uses two different >> fixed rate-ctrl settings, one for non-data (bcast, mgt-frames, etc) and another >> for data frames. The non-data one was not being set when user configured >> fixed rates, so beacons went out at 1Mbps. >> >> I updated CT firmware (beta-14) to set both data and non-data to the same >> value when the driver specifies the rates... Seems to work...any idea >> if this is a bad idea in practice? > > Rate control is applicable to unicast frame whether it is > management/data. Broadcast/Multicast rate is required for > management/data (usually the lowest transmission rate 5GHz is 6Mbps). > > So it is more sensible if we can configure the broadcast/multicast > rate and also disable the rate control for unicast frame by using > fixed rate. User-space API doesn't give the ability to set different fixed rates for different packet types, as far as I know. So, the current firmware just ignores the fixed rate for management and broadcast frames. My firmware change makes the fixed rate apply equally to all types of frames. Should I make my change optional for mgt/bcast , or should it always set mgt/bcast rates to the same fixed rates as data packets use? Thanks, Ben > > --- > Chun-Yeow > -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Any idea why we cannot disable /b rates? 2015-02-25 5:02 ` Ben Greear @ 2015-02-25 10:30 ` Yeoh Chun-Yeow 2015-02-25 23:25 ` Ben Greear 0 siblings, 1 reply; 7+ messages in thread From: Yeoh Chun-Yeow @ 2015-02-25 10:30 UTC (permalink / raw) To: Ben Greear; +Cc: ath10k On Wed, Feb 25, 2015 at 1:02 PM, Ben Greear <greearb@candelatech.com> wrote: > > > On 02/24/2015 06:45 PM, Yeoh Chun-Yeow wrote: >> >> On Wed, Feb 25, 2015 at 3:44 AM, Ben Greear <greearb@candelatech.com> >> wrote: >>> >>> Ok, so I found the problem. Appears that the firmware uses two different >>> fixed rate-ctrl settings, one for non-data (bcast, mgt-frames, etc) and >>> another >>> for data frames. The non-data one was not being set when user configured >>> fixed rates, so beacons went out at 1Mbps. >>> >>> I updated CT firmware (beta-14) to set both data and non-data to the same >>> value when the driver specifies the rates... Seems to work...any idea >>> if this is a bad idea in practice? >> >> >> Rate control is applicable to unicast frame whether it is >> management/data. Broadcast/Multicast rate is required for >> management/data (usually the lowest transmission rate 5GHz is 6Mbps). >> >> So it is more sensible if we can configure the broadcast/multicast >> rate and also disable the rate control for unicast frame by using >> fixed rate. > > > User-space API doesn't give the ability to set different fixed rates for > different packet types, as far as I know. > > So, the current firmware just ignores the fixed rate for management and > broadcast > frames. > > My firmware change makes the fixed rate apply equally to all types of > frames. > > Should I make my change optional for mgt/bcast , or should it always set > mgt/bcast rates to the > same fixed rates as data packets use? In iw, we have the following: dev <devname> set mcast_rate <rate in Mbps> dev <devname> set bitrates [legacy-<2.4|5> <legacy rate in Mbps>*] [mcs-<2.4|5> <MCS index>*] mcast-rate should be something set for broadcast/multicast frame including the management and data frame. This allows us to have in example beacon frame to be transmitted with higher rate from 1Mbps at 2.4GHz and 6Mbps at 5GHz. --- Chun-Yeow _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Any idea why we cannot disable /b rates? 2015-02-25 10:30 ` Yeoh Chun-Yeow @ 2015-02-25 23:25 ` Ben Greear 2015-03-10 23:59 ` Ben Greear 0 siblings, 1 reply; 7+ messages in thread From: Ben Greear @ 2015-02-25 23:25 UTC (permalink / raw) To: Yeoh Chun-Yeow; +Cc: ath10k On 02/25/2015 02:30 AM, Yeoh Chun-Yeow wrote: > On Wed, Feb 25, 2015 at 1:02 PM, Ben Greear <greearb@candelatech.com> wrote: >> >> >> On 02/24/2015 06:45 PM, Yeoh Chun-Yeow wrote: >>> >>> On Wed, Feb 25, 2015 at 3:44 AM, Ben Greear <greearb@candelatech.com> >>> wrote: >>>> >>>> Ok, so I found the problem. Appears that the firmware uses two different >>>> fixed rate-ctrl settings, one for non-data (bcast, mgt-frames, etc) and >>>> another >>>> for data frames. The non-data one was not being set when user configured >>>> fixed rates, so beacons went out at 1Mbps. >>>> >>>> I updated CT firmware (beta-14) to set both data and non-data to the same >>>> value when the driver specifies the rates... Seems to work...any idea >>>> if this is a bad idea in practice? >>> >>> >>> Rate control is applicable to unicast frame whether it is >>> management/data. Broadcast/Multicast rate is required for >>> management/data (usually the lowest transmission rate 5GHz is 6Mbps). >>> >>> So it is more sensible if we can configure the broadcast/multicast >>> rate and also disable the rate control for unicast frame by using >>> fixed rate. >> >> >> User-space API doesn't give the ability to set different fixed rates for >> different packet types, as far as I know. >> >> So, the current firmware just ignores the fixed rate for management and >> broadcast >> frames. >> >> My firmware change makes the fixed rate apply equally to all types of >> frames. >> >> Should I make my change optional for mgt/bcast , or should it always set >> mgt/bcast rates to the >> same fixed rates as data packets use? > > In iw, we have the following: > dev <devname> set mcast_rate <rate in Mbps> > dev <devname> set bitrates [legacy-<2.4|5> <legacy rate in Mbps>*] > [mcs-<2.4|5> <MCS index>*] > > mcast-rate should be something set for broadcast/multicast frame > including the management and data frame. This allows us to have in > example beacon frame to be transmitted with higher rate from 1Mbps at > 2.4GHz and 6Mbps at 5GHz. Thanks...I'll try to figure out how to work this into my firmware. But, it will require driver changes specific to my firmware as far as I can tell, so it will never make it upstream... Thanks, Ben -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Any idea why we cannot disable /b rates? 2015-02-25 23:25 ` Ben Greear @ 2015-03-10 23:59 ` Ben Greear 0 siblings, 0 replies; 7+ messages in thread From: Ben Greear @ 2015-03-10 23:59 UTC (permalink / raw) To: Yeoh Chun-Yeow; +Cc: ath10k On 02/25/2015 03:25 PM, Ben Greear wrote: > On 02/25/2015 02:30 AM, Yeoh Chun-Yeow wrote: >> On Wed, Feb 25, 2015 at 1:02 PM, Ben Greear <greearb@candelatech.com> wrote: >>> >>> >>> On 02/24/2015 06:45 PM, Yeoh Chun-Yeow wrote: >>>> >>>> On Wed, Feb 25, 2015 at 3:44 AM, Ben Greear <greearb@candelatech.com> >>>> wrote: >>>>> >>>>> Ok, so I found the problem. Appears that the firmware uses two different >>>>> fixed rate-ctrl settings, one for non-data (bcast, mgt-frames, etc) and >>>>> another >>>>> for data frames. The non-data one was not being set when user configured >>>>> fixed rates, so beacons went out at 1Mbps. >>>>> >>>>> I updated CT firmware (beta-14) to set both data and non-data to the same >>>>> value when the driver specifies the rates... Seems to work...any idea >>>>> if this is a bad idea in practice? >>>> >>>> >>>> Rate control is applicable to unicast frame whether it is >>>> management/data. Broadcast/Multicast rate is required for >>>> management/data (usually the lowest transmission rate 5GHz is 6Mbps). >>>> >>>> So it is more sensible if we can configure the broadcast/multicast >>>> rate and also disable the rate control for unicast frame by using >>>> fixed rate. >>> >>> >>> User-space API doesn't give the ability to set different fixed rates for >>> different packet types, as far as I know. >>> >>> So, the current firmware just ignores the fixed rate for management and >>> broadcast >>> frames. >>> >>> My firmware change makes the fixed rate apply equally to all types of >>> frames. >>> >>> Should I make my change optional for mgt/bcast , or should it always set >>> mgt/bcast rates to the >>> same fixed rates as data packets use? >> >> In iw, we have the following: >> dev <devname> set mcast_rate <rate in Mbps> >> dev <devname> set bitrates [legacy-<2.4|5> <legacy rate in Mbps>*] >> [mcs-<2.4|5> <MCS index>*] >> >> mcast-rate should be something set for broadcast/multicast frame >> including the management and data frame. This allows us to have in >> example beacon frame to be transmitted with higher rate from 1Mbps at >> 2.4GHz and 6Mbps at 5GHz. > > Thanks...I'll try to figure out how to work this into my firmware. But, it will > require driver changes specific to my firmware as far as I can tell, > so it will never make it upstream... From what I can tell, you can only set mcast rates on IBSS and mesh interfaces, so my firmware changes will probably remain the only way to do this until someone adds support to the mac80211 stack and driver. The good news is that my firmware change no driver changes, so it should work with upstream kernels. I have uploaded another beta firmware that also fixes the rate for mcast/broadcast traffic (which was not properly being set when trying to set the rate with iw previously). To set HT rates, you need my 'iw' patch I posted earlier to linux-wireless...and which may be found here: https://github.com/greearb/iw-ct See release notes and binaries here: http://www.candelatech.com/downloads/ath10k-fw-beta/ Thanks, Ben > > Thanks, > Ben > > -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-03-10 23:59 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-02-24 17:43 Any idea why we cannot disable /b rates? Ben Greear 2015-02-24 19:44 ` Ben Greear 2015-02-25 2:45 ` Yeoh Chun-Yeow 2015-02-25 5:02 ` Ben Greear 2015-02-25 10:30 ` Yeoh Chun-Yeow 2015-02-25 23:25 ` Ben Greear 2015-03-10 23:59 ` Ben Greear
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox