From: Kalle Valo <kvalo@qca.qualcomm.com>
To: greearb@candelatech.com
Cc: ath10k@lists.infradead.org
Subject: Re: [PATCH v5] ath10k: save firmware debug log messages.
Date: Tue, 2 Sep 2014 16:38:09 +0300 [thread overview]
Message-ID: <8738cam9by.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1409239441-4878-1-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Thu, 28 Aug 2014 08:24:01 -0700")
(Dropping linux-wireless)
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> They may be dumped through the firmware dump debugfs
> file.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
Before I start looking at this in detail: this looks fragile and
complicated from ath10k point of view. Why not just take a dump of the
whole firmware memory and postprocess this, with whatever else we might
need from the firmware? That's a lot easier to maintain.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-09-02 13:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 15:24 [PATCH v5] ath10k: save firmware debug log messages greearb
2014-09-02 13:38 ` Kalle Valo [this message]
2014-09-02 13:51 ` Michal Kazior
2014-09-02 14:25 ` Kalle Valo
2014-09-02 16:03 ` Ben Greear
2014-09-02 14:52 ` Ben Greear
2014-09-02 14:58 ` Li, Yanbo
2014-09-02 15:50 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738cam9by.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox