Re: [PATCH v5] ath10k: save firmware debug log messages.

[Kalle Valo <kvalo@qca.qualcomm.com>]

Michal Kazior <michal.kazior@tieto.com> writes:

> On 2 September 2014 15:38, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> (Dropping linux-wireless)
>>
>> greearb@candelatech.com writes:
>>
>>> From: Ben Greear <greearb@candelatech.com>
>>>
>>> They may be dumped through the firmware dump debugfs
>>> file.
>>>
>>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>>
>> Before I start looking at this in detail: this looks fragile and
>> complicated from ath10k point of view. Why not just take a dump of the
>> whole firmware memory and postprocess this, with whatever else we might
>> need from the firmware? That's a lot easier to maintain.
>
> I like the idea although it still makes sense to keep some sort of a
> circular buffer for the debug mesg events delivered via wmi, does it
> not?

How would ath10k use those stored debug mesg events? Attach them to the
firmare crash dump file? Or did you have something else in mind?

But most importantly, would that be useful? Does the firmware send debug
events now? Or would it require the user to change the firmware log
level through fw_dbglog debugfs file before the crash?

I want to avoid a situation where we have to maintain a feature which
nobody uses.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k