From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 5/5] ath10k: flush hif buffers before recovery
Date: Thu, 7 Aug 2014 12:30:07 +0300 [thread overview]
Message-ID: <8738d84pgg.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1407402308-29899-6-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 7 Aug 2014 11:05:08 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> Transport buffers weren't flushed and processed
> before queueing hw recovery request to mac80211.
>
> This could in theory result in an unwanted htt/wmi
> rx events being processed while mac80211 recovers
> the device and possibly interfere or even crash
> the system.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
This one had a conflict in ath-next-test, I changed the patch to this:
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -666,6 +666,7 @@ static void ath10k_core_restart(struct work_struct *work)
case ATH10K_STATE_ON:
ar->state = ATH10K_STATE_RESTARTING;
ath10k_scan_finish(ar);
+ ath10k_hif_stop(ar);
ieee80211_restart_hw(ar->hw);
break;
case ATH10K_STATE_OFF:
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-08-07 9:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 9:05 [PATCH 0/5] ath10k: fixes 2014-08-07, part 3 Michal Kazior
2014-08-07 9:05 ` [PATCH 1/5] ath10k: rework posting pci rx buffers Michal Kazior
2014-08-14 12:05 ` Kalle Valo
2014-08-07 9:05 ` [PATCH 2/5] ath10k: dont reset the chip on hif_stop Michal Kazior
2014-08-08 9:14 ` Michal Kazior
2014-08-07 9:05 ` [PATCH 3/5] ath10k: ignore ar_pci->started in pipe cleanup Michal Kazior
2014-08-07 9:05 ` [PATCH 4/5] ath10k: remove ar_pci->started Michal Kazior
2014-08-07 9:05 ` [PATCH 5/5] ath10k: flush hif buffers before recovery Michal Kazior
2014-08-07 9:30 ` Kalle Valo [this message]
2014-08-07 9:39 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738d84pgg.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox