From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 1/5] ath10k: rework posting pci rx buffers
Date: Thu, 14 Aug 2014 15:05:07 +0300 [thread overview]
Message-ID: <87oavnmg3w.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1407402308-29899-2-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 7 Aug 2014 11:05:04 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> It was possible on a host system running low on
> memory to end up with no rx buffers on pci pipes.
>
> This also cleans up the code a bit and, as a side
> effect, makes it possible to call
> ath10k_hif_start() more than once.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
The rework is relatively big so it would be good to have a short
overview how you change it.
> +static void ath10k_pci_rx_replenish(struct ath10k_pci_pipe *pipe)
> +{
> + struct ath10k *ar = pipe->hif_ce_state;
> + struct ath10k_pci *ar_pci = ath10k_pci_priv(ar);
> + int ret;
> +
> + spin_lock_bh(&ar_pci->ce_lock);
> + ret = __ath10k_pci_rx_post_pipe(pipe);
> + spin_unlock_bh(&ar_pci->ce_lock);
> +
> + if (ret) {
> + ath10k_warn("failed to replenish pci rx pipe %d: %d, arming retry timer\n",
> + pipe->pipe_num, ret);
> + mod_timer(&ar_pci->rx_replenish_retry,
> + ATH10K_PCI_RX_REPLENISH_RETRY_MS);
> + }
> +}
Buildbot sent a warning about this one which I think is valid:
drivers/net/wireless/ath/ath10k/pci.c:380 ath10k_pci_rx_replenish() warn: mod_timer() takes an absolute \
time not an offset.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-08-14 12:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 9:05 [PATCH 0/5] ath10k: fixes 2014-08-07, part 3 Michal Kazior
2014-08-07 9:05 ` [PATCH 1/5] ath10k: rework posting pci rx buffers Michal Kazior
2014-08-14 12:05 ` Kalle Valo [this message]
2014-08-07 9:05 ` [PATCH 2/5] ath10k: dont reset the chip on hif_stop Michal Kazior
2014-08-08 9:14 ` Michal Kazior
2014-08-07 9:05 ` [PATCH 3/5] ath10k: ignore ar_pci->started in pipe cleanup Michal Kazior
2014-08-07 9:05 ` [PATCH 4/5] ath10k: remove ar_pci->started Michal Kazior
2014-08-07 9:05 ` [PATCH 5/5] ath10k: flush hif buffers before recovery Michal Kazior
2014-08-07 9:30 ` Kalle Valo
2014-08-07 9:39 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oavnmg3w.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox