From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Peter Oh <poh@codeaurora.org>, ath10k@lists.infradead.org
Subject: Re: [PATCH 2/2] ath10k: do not use coherent memory for tx buffers
Date: Wed, 25 Nov 2015 12:37:08 +0200 [thread overview]
Message-ID: <87610qpdpn.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <56543CAE.4030803@openwrt.org> (Felix Fietkau's message of "Tue, 24 Nov 2015 11:32:14 +0100")
Felix Fietkau <nbd@openwrt.org> writes:
>>> However, on the device that I'm testing on
>>> (IPQ806x based), this patch makes the difference between working and
>>> non-working wifi, fixing the regression introduced by your pre-allocated
>>> coherent memory patch.
>>
>> Thank you for the catch up and fix.
>> Btw, the regression can be fixed by using GFP_KERNEL, instead of
>> GFP_DMA, right?
>
> I just did some timing measurements, and it seems that the DMA coherent
> variant is roughly 200 nanoseconds faster. Maybe the extra latency is
> caused by the CPU filling the cacheline from RAM first.
>
> Kalle, please only merge the first one and drop this patch.
> I will send a replacement for it.
Ok, patch 2 dropped.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2015-11-25 10:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 13:18 [PATCH 1/2] ath10k: do not use coherent memory for allocated device memory chunks Felix Fietkau
2015-11-23 13:18 ` [PATCH 2/2] ath10k: do not use coherent memory for tx buffers Felix Fietkau
2015-11-23 17:25 ` Peter Oh
2015-11-23 18:02 ` Sebastian Gottschall
2015-11-23 18:25 ` Peter Oh
2015-11-23 18:34 ` Felix Fietkau
2015-11-23 18:18 ` Felix Fietkau
2015-11-23 18:50 ` Peter Oh
2015-11-24 10:32 ` Felix Fietkau
2015-11-25 10:37 ` Kalle Valo [this message]
2015-11-30 10:29 ` [PATCH 1/2] ath10k: do not use coherent memory for allocated device memory chunks Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87610qpdpn.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=nbd@openwrt.org \
--cc=poh@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox