From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 1/2] ath10k: do not use coherent memory for allocated device memory chunks
Date: Mon, 30 Nov 2015 12:29:31 +0200 [thread overview]
Message-ID: <87wpszkcfo.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1448284729-98078-1-git-send-email-nbd@openwrt.org> (Felix Fietkau's message of "Mon, 23 Nov 2015 14:18:48 +0100")
Felix Fietkau <nbd@openwrt.org> writes:
> Coherent memory is more expensive to allocate (and constrained on some
> architectures where it has to be pre-allocated). It is also completely
> unnecessary, since the host has no reason to even access these allocated
> memory spaces
>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
I see a new compiler warning:
drivers/net/wireless/ath/ath10k/wmi.c: In function
'ath10k_wmi_event_service_ready_work':
drivers/net/wireless/ath/ath10k/wmi.c:4347:30: warning: 'pool_size' may
be used uninitialized in this function [-Wuninitialized]
drivers/net/wireless/ath/ath10k/wmi.c:4319:6: note: 'pool_size' was
declared here
Seems to be false and maybe because my gcc is pretty old:
gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
But anyway it would be nice if this can be avoided.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2015-11-30 10:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 13:18 [PATCH 1/2] ath10k: do not use coherent memory for allocated device memory chunks Felix Fietkau
2015-11-23 13:18 ` [PATCH 2/2] ath10k: do not use coherent memory for tx buffers Felix Fietkau
2015-11-23 17:25 ` Peter Oh
2015-11-23 18:02 ` Sebastian Gottschall
2015-11-23 18:25 ` Peter Oh
2015-11-23 18:34 ` Felix Fietkau
2015-11-23 18:18 ` Felix Fietkau
2015-11-23 18:50 ` Peter Oh
2015-11-24 10:32 ` Felix Fietkau
2015-11-25 10:37 ` Kalle Valo
2015-11-30 10:29 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpszkcfo.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox