From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Matthias Kaehlcke <mka@google.com>
Cc: Matthias Kaehlcke <mka@chromium.org>,
Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Remove trace about getting temperature
Date: Thu, 12 Mar 2015 15:17:51 +0200 [thread overview]
Message-ID: <87d24euzgg.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CAKZ8rEOVf4q_i7at=h3PiwwGDNeuiEL467wFCOwADwd0BhtbCw@mail.gmail.com> (Matthias Kaehlcke's message of "Tue, 10 Mar 2015 09:24:52 -0700")
Matthias Kaehlcke <mka@google.com> writes:
> > - ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi pdev get temperature\n");
> > return skb;
>
> I'm worried that this is dangerous, as that means that not all WMI
> commands will be in debug and something might be missed because of that.
>
>
> I see your concern
>
>
> Isn't there any other way? Like implementing ath10k_dbg_ratelimit()? Or
> adding a new log level?
>
>
> Switching to dynamic debugging (dev_dbg, ...) could be an option. Debug
> messages would be disabled by default but can be enabled at runtime
I don't really like dynamic debugging framework as it's not really
convenient with bigger drivers like ath10k. Is it possible to add
support for dynamic debugging without sacrificing the current debug
functionality, especially setting debug levels via debug_mask
parameters?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2015-03-12 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 18:26 [PATCH] ath10k: Remove trace about getting temperature Matthias Kaehlcke
2015-03-10 15:54 ` Kalle Valo
2015-03-10 16:34 ` Matthias Kaehlcke
[not found] ` <CAKZ8rEOVf4q_i7at=h3PiwwGDNeuiEL467wFCOwADwd0BhtbCw@mail.gmail.com>
2015-03-12 13:17 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d24euzgg.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=mka@chromium.org \
--cc=mka@google.com \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox