ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
	ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Remove trace about getting temperature
Date: Tue, 10 Mar 2015 17:54:55 +0200	[thread overview]
Message-ID: <87h9tsyhin.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1424802385-23017-1-git-send-email-mka@chromium.org> (Matthias Kaehlcke's message of "Tue, 24 Feb 2015 10:26:25 -0800")

Matthias Kaehlcke <mka@chromium.org> writes:

> When ath10k debugging is enabled this trace generates a log entry
> every time the chip temperature is read. On systems polling the
> temperature this clutters the log with entries which aren't
> particularly useful. Remove this trace.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>  drivers/net/wireless/ath/ath10k/wmi.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
> index aeea1c7..1c86984 100644
> --- a/drivers/net/wireless/ath/ath10k/wmi.c
> +++ b/drivers/net/wireless/ath/ath10k/wmi.c
> @@ -4881,7 +4881,6 @@ ath10k_wmi_10_2_op_gen_pdev_get_temperature(struct ath10k *ar)
>  	if (!skb)
>  		return ERR_PTR(-ENOMEM);
>  
> -	ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi pdev get temperature\n");
>  	return skb;

I'm worried that this is dangerous, as that means that not all WMI
commands will be in debug and something might be missed because of that.

Isn't there any other way? Like implementing ath10k_dbg_ratelimit()? Or
adding a new log level?

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2015-03-10 15:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 18:26 [PATCH] ath10k: Remove trace about getting temperature Matthias Kaehlcke
2015-03-10 15:54 ` Kalle Valo [this message]
2015-03-10 16:34   ` Matthias Kaehlcke
     [not found]   ` <CAKZ8rEOVf4q_i7at=h3PiwwGDNeuiEL467wFCOwADwd0BhtbCw@mail.gmail.com>
2015-03-12 13:17     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9tsyhin.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=mka@chromium.org \
    --cc=rmanohar@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox