public inbox for ath10k@lists.infradead.org
 help / color / mirror / Atom feed
* Re: [PATCH] ath10k: Fixed "Failed to wake target" QCA6174
       [not found] <20191030125035.31848-1-rohn.ch@gmail.com>
@ 2019-10-30 14:25 ` Kalle Valo
  0 siblings, 0 replies; only message in thread
From: Kalle Valo @ 2019-10-30 14:25 UTC (permalink / raw)
  To: liupold; +Cc: netdev, linux-wireless, linux-kernel, ath10k

+ ath10k list

liupold <rohn.ch@gmail.com> writes:

> There is a issue with card about waking up during boot and from suspend
> the only way to prevent it (is seems) by making pci_ps = false,
> on Acer Swift 3 (ryzen 2500u).

Can you provide dmesg output when this problem happens? Was QCA6174
installed to Swift 3 by default at the factory or did you install it
afterwards on your own?

> Signed-off-by: liupold <rohn.ch@gmail.com>

Is 'liupold' your full legal name?

> ---
>  drivers/net/wireless/ath/ath10k/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
> index a0b4d265c6eb..653590342619 100644
> --- a/drivers/net/wireless/ath/ath10k/pci.c
> +++ b/drivers/net/wireless/ath/ath10k/pci.c
> @@ -3514,7 +3514,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
>  	case QCA6164_2_1_DEVICE_ID:
>  	case QCA6174_2_1_DEVICE_ID:
>  		hw_rev = ATH10K_HW_QCA6174;
> -		pci_ps = true;
> +		pci_ps = false;
>  		pci_soft_reset = ath10k_pci_warm_reset;
>  		pci_hard_reset = ath10k_pci_qca6174_chip_reset;
>  		targ_cpu_to_ce_addr = ath10k_pci_qca6174_targ_cpu_to_ce_addr;

This increases power consumption for all QCA6174 devices so I'm not
eager to do this.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-10-30 14:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20191030125035.31848-1-rohn.ch@gmail.com>
2019-10-30 14:25 ` [PATCH] ath10k: Fixed "Failed to wake target" QCA6174 Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox