From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 6/6] ath10k: move fw init print
Date: Thu, 14 Aug 2014 11:27:29 +0300 [thread overview]
Message-ID: <87egwjo4r2.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <87ppg6qh3z.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Tue, 12 Aug 2014 10:53:04 +0300")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
> Michal Kazior <michal.kazior@tieto.com> writes:
>
>> Firmware probing is done only once when driver is
>> registered and firmware version is guaranteed to
>> remain the same until driver is unregistered.
>>
>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>
> [...]
>
>> - __set_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags);
>
> Doesn't this break this print in pci.c:
>
> if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags))
> ath10k_info("pci irq %s irq_mode %d reset_mode %d\n",
> irq_mode, ath10k_pci_irq_mode,
> ath10k_pci_reset_mode);
Ah, now I understand. You rework that part in patch "ath10k: setup irq
method in probe" which was just in a different patchset. Then this extra
print during interface up is ok, as it just happens between the two
patches.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-08-14 8:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 9:03 [PATCH 0/6] ath10k: fixes 2014-08-07, part 1 Michal Kazior
2014-08-07 9:03 ` [PATCH 1/6] ath10k: embed ar_pci inside ar Michal Kazior
2014-08-07 9:03 ` [PATCH 2/6] ath10k: remove target soc ps code Michal Kazior
2014-08-08 10:45 ` Kalle Valo
2014-08-08 11:00 ` Michal Kazior
2014-08-08 11:04 ` Kalle Valo
2014-08-09 18:21 ` Kalle Valo
2014-08-09 18:24 ` Kalle Valo
2014-08-07 9:03 ` [PATCH 3/6] ath10k: remove pci features var Michal Kazior
2014-08-08 11:01 ` Kalle Valo
2014-08-07 9:03 ` [PATCH 4/6] ath10k: group some pci probing helpers Michal Kazior
2014-08-07 9:03 ` [PATCH 5/6] ath10k: remove htc->stopped Michal Kazior
2014-08-07 9:03 ` [PATCH 6/6] ath10k: move fw init print Michal Kazior
2014-08-12 7:53 ` Kalle Valo
2014-08-14 8:27 ` Kalle Valo [this message]
2014-08-12 7:56 ` [PATCH 0/6] ath10k: fixes 2014-08-07, part 1 Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egwjo4r2.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox