From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 2/6] ath10k: remove target soc ps code
Date: Fri, 8 Aug 2014 14:04:13 +0300 [thread overview]
Message-ID: <87zjffxmxe.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQnvS2C9_C7qkrX5cPLa8weHx_FmS8Gd=d2Pf=EAmf9EiQ@mail.gmail.com> (Michal Kazior's message of "Fri, 8 Aug 2014 13:00:56 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> On 8 August 2014 12:45, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior@tieto.com> writes:
>>
>>> The soc powersave was disabled by default. It
>>> never was fully tested. Some hw apparently had
>>> problems with it and the implementation itself had
>>> a possible race.
>>>
>>> Just remove the refcounting and simply wake up the
>>> device when probing and put to sleep when
>>> removing.
>>>
>>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>>
>> This one introduced new warnings:
>>
>> drivers/net/wireless/ath/ath10k/pci.c:646:5: warning: symbol 'ath10k_pci_wake' was not declared. Should it be static?
>> drivers/net/wireless/ath/ath10k/pci.c:653:6: warning: symbol 'ath10k_pci_sleep' was not declared. Should it be static?
>
> I didn't catch this for some reason. Can you share how you run
> checkpatch, please?
I think these are coming from sparse, in essence I run this:
make drivers/net/wireless/ath/ath10k/ C=2 CF="-D__CHECK_ENDIAN__"
Which reminds me that I should add -D__CHECK_ENDIAN__ to the makefile.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-08-08 11:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 9:03 [PATCH 0/6] ath10k: fixes 2014-08-07, part 1 Michal Kazior
2014-08-07 9:03 ` [PATCH 1/6] ath10k: embed ar_pci inside ar Michal Kazior
2014-08-07 9:03 ` [PATCH 2/6] ath10k: remove target soc ps code Michal Kazior
2014-08-08 10:45 ` Kalle Valo
2014-08-08 11:00 ` Michal Kazior
2014-08-08 11:04 ` Kalle Valo [this message]
2014-08-09 18:21 ` Kalle Valo
2014-08-09 18:24 ` Kalle Valo
2014-08-07 9:03 ` [PATCH 3/6] ath10k: remove pci features var Michal Kazior
2014-08-08 11:01 ` Kalle Valo
2014-08-07 9:03 ` [PATCH 4/6] ath10k: group some pci probing helpers Michal Kazior
2014-08-07 9:03 ` [PATCH 5/6] ath10k: remove htc->stopped Michal Kazior
2014-08-07 9:03 ` [PATCH 6/6] ath10k: move fw init print Michal Kazior
2014-08-12 7:53 ` Kalle Valo
2014-08-14 8:27 ` Kalle Valo
2014-08-12 7:56 ` [PATCH 0/6] ath10k: fixes 2014-08-07, part 1 Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjffxmxe.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox