From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: ath10k@lists.infradead.org, kbuild@01.org,
kbuild test robot <fengguang.wu@intel.com>,
michal.kazior@tieto.com, dan.carpenter@oracle.com
Subject: Re: [ath6kl:ath-next-test 47/51] drivers/net/wireless/ath/ath10k/debug.c:169:5-8: Unneeded variable: "ret". Return "0" on line 178
Date: Tue, 26 Aug 2014 12:05:52 +0300 [thread overview]
Message-ID: <87iolf39jj.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1408260856130.2436@hadrien> (Julia Lawall's message of "Tue, 26 Aug 2014 08:59:15 +0200 (CEST)")
+ ath10k@lists.infradead.org
Julia Lawall <julia.lawall@lip6.fr> writes:
> On Tue, 26 Aug 2014, kbuild test robot wrote:
>
>> tree: git://github.com/kvalo/ath ath-next-test
>> head: 077256daf111b4db074ac602bed1e96e95e3a4a4
>> commit: 6b7b27b12f4af628305940c1c083b8558d7618ac [47/51] ath10k: improve logging to include dev id
>> :::::: branch date: 16 hours ago
>> :::::: commit date: 16 hours ago
>>
>> >> drivers/net/wireless/ath/ath10k/debug.c:169:5-8: Unneeded variable: "ret". Return "0" on line 178
>>
>> Please consider folding the attached diff :-)
>
> The variable is indeed not needed. I guess the function returns a value
> for parallelism with ath10k_err. But the function dev_err used in that
> function returns a value, while the macro dev_warn_ratelimited used in
> this function does not.
Ok. If it's ok for Michal I'll fold the patch before I commit it.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next parent reply other threads:[~2014-08-26 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <53fbf631.S4reREVxRQQKt8Ff%fengguang.wu@intel.com>
[not found] ` <alpine.DEB.2.10.1408260856130.2436@hadrien>
2014-08-26 9:05 ` Kalle Valo [this message]
2014-08-26 9:15 ` [ath6kl:ath-next-test 47/51] drivers/net/wireless/ath/ath10k/debug.c:169:5-8: Unneeded variable: "ret". Return "0" on line 178 Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iolf39jj.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=julia.lawall@lip6.fr \
--cc=kbuild@01.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox