* Re: [ath6kl:ath-next-test 47/51] drivers/net/wireless/ath/ath10k/debug.c:169:5-8: Unneeded variable: "ret". Return "0" on line 178 [not found] ` <alpine.DEB.2.10.1408260856130.2436@hadrien> @ 2014-08-26 9:05 ` Kalle Valo 2014-08-26 9:15 ` Michal Kazior 0 siblings, 1 reply; 2+ messages in thread From: Kalle Valo @ 2014-08-26 9:05 UTC (permalink / raw) To: Julia Lawall Cc: ath10k, kbuild, kbuild test robot, michal.kazior, dan.carpenter + ath10k@lists.infradead.org Julia Lawall <julia.lawall@lip6.fr> writes: > On Tue, 26 Aug 2014, kbuild test robot wrote: > >> tree: git://github.com/kvalo/ath ath-next-test >> head: 077256daf111b4db074ac602bed1e96e95e3a4a4 >> commit: 6b7b27b12f4af628305940c1c083b8558d7618ac [47/51] ath10k: improve logging to include dev id >> :::::: branch date: 16 hours ago >> :::::: commit date: 16 hours ago >> >> >> drivers/net/wireless/ath/ath10k/debug.c:169:5-8: Unneeded variable: "ret". Return "0" on line 178 >> >> Please consider folding the attached diff :-) > > The variable is indeed not needed. I guess the function returns a value > for parallelism with ath10k_err. But the function dev_err used in that > function returns a value, while the macro dev_warn_ratelimited used in > this function does not. Ok. If it's ok for Michal I'll fold the patch before I commit it. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [ath6kl:ath-next-test 47/51] drivers/net/wireless/ath/ath10k/debug.c:169:5-8: Unneeded variable: "ret". Return "0" on line 178 2014-08-26 9:05 ` [ath6kl:ath-next-test 47/51] drivers/net/wireless/ath/ath10k/debug.c:169:5-8: Unneeded variable: "ret". Return "0" on line 178 Kalle Valo @ 2014-08-26 9:15 ` Michal Kazior 0 siblings, 0 replies; 2+ messages in thread From: Michal Kazior @ 2014-08-26 9:15 UTC (permalink / raw) To: Kalle Valo Cc: Julia Lawall, kbuild, kbuild test robot, ath10k@lists.infradead.org, Dan Carpenter On 26 August 2014 11:05, Kalle Valo <kvalo@qca.qualcomm.com> wrote: > + ath10k@lists.infradead.org > > Julia Lawall <julia.lawall@lip6.fr> writes: > >> On Tue, 26 Aug 2014, kbuild test robot wrote: >> >>> tree: git://github.com/kvalo/ath ath-next-test >>> head: 077256daf111b4db074ac602bed1e96e95e3a4a4 >>> commit: 6b7b27b12f4af628305940c1c083b8558d7618ac [47/51] ath10k: improve logging to include dev id >>> :::::: branch date: 16 hours ago >>> :::::: commit date: 16 hours ago >>> >>> >> drivers/net/wireless/ath/ath10k/debug.c:169:5-8: Unneeded variable: "ret". Return "0" on line 178 >>> >>> Please consider folding the attached diff :-) >> >> The variable is indeed not needed. I guess the function returns a value >> for parallelism with ath10k_err. But the function dev_err used in that >> function returns a value, while the macro dev_warn_ratelimited used in >> this function does not. > > Ok. If it's ok for Michal I'll fold the patch before I commit it. I'm okay with that. Thanks. Michał _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-26 9:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <53fbf631.S4reREVxRQQKt8Ff%fengguang.wu@intel.com>
[not found] ` <alpine.DEB.2.10.1408260856130.2436@hadrien>
2014-08-26 9:05 ` [ath6kl:ath-next-test 47/51] drivers/net/wireless/ath/ath10k/debug.c:169:5-8: Unneeded variable: "ret". Return "0" on line 178 Kalle Valo
2014-08-26 9:15 ` Michal Kazior
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox