From: Kalle Valo <kvalo@qca.qualcomm.com>
To: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v6 00/10] ath10k: sdio support
Date: Tue, 28 Mar 2017 11:53:51 +0000 [thread overview]
Message-ID: <87k279wrao.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <148959263520.31432.8488419244476213373.stgit@potku.adurom.net> (Kalle Valo's message of "Wed, 15 Mar 2017 17:44:41 +0200")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
> I did some changes while reviewing Erik's SDIO patches. Only compile
> tested, I don't have any SDIO boards at the moment.
[...]
> still todo:
>
> o fix remaining memory leaks (if any)
>
> o endian support, eg ath10k_sdio_hif_set_mbox_sleep()
>
> o are ath10k_sdio_io() and ath10k_sdio_read_write_sync() really
> necessary? looks like just an unnecessary abstraction layer
It took me longer than I planned, but here are my notes about what I'm
planning to do to remove unnecessary ath10k_sdio_io() abstraction:
ath10k_sdio_read_write_sync():
HIF_RD_SYNC_BLOCK_FIX -> ath10k_sdio_readsb()
HIF_RD_SYNC_BYTE_INC -> ath10k_sdio_read(), ath10k_sdio_read32()
HIF_WR_SYNC_BYTE_FIX -> ath10k_sdio_writesb()
HIF_WR_SYNC_BYTE_INC -> ath10k_sdio_write()
ath10k_sdio_prep_async_req():
HIF_WRITE -> HIF_WR_SYNC_BYTE_INC -> ath10k_sdio_write()
ath10k_sdio_read/write32():
sdio_readl()/sdio_writel() (those use endian macros)
ath10k_sdio_readsb():
len = round_down(len, ar_sdio->mbox_info.block_size);
sdio_memcpy_fromio(len)
With these changes I'm hoping to get rid of also the memory leaks and
have proper endian support.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-03-28 11:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 15:44 [PATCH v6 00/10] ath10k: sdio support Kalle Valo
2017-03-15 15:44 ` [PATCH v6 01/10] ath10k: htc: made static function public Kalle Valo
2017-03-15 15:45 ` [PATCH v6 02/10] ath10k: htc: rx trailer lookahead support Kalle Valo
2017-03-15 15:45 ` [PATCH v6 03/10] ath10k: htc: move htc ctrl ep connect to htc_init Kalle Valo
2017-03-16 1:06 ` Ryan Hsu
2017-03-16 16:13 ` Erik Stromdahl
2017-03-15 15:45 ` [PATCH v6 04/10] ath10k: htc: refactorization Kalle Valo
2017-03-15 15:45 ` [PATCH v6 05/10] ath10k: various sdio related definitions Kalle Valo
2017-03-15 15:46 ` [PATCH v6 06/10] ath10k: add sdio extra initializations Kalle Valo
2017-03-16 1:18 ` Ryan Hsu
2017-03-23 15:59 ` Kalle Valo
2017-03-15 15:46 ` [PATCH v6 07/10] ath10k: sdio get target info Kalle Valo
2017-03-15 15:46 ` [PATCH v6 08/10] ath10k: htc: ready_ext msg support Kalle Valo
2017-03-15 15:46 ` [PATCH v6 09/10] ath10k: different fw file names for usb and sdio Kalle Valo
2017-03-16 21:08 ` Ryan Hsu
2017-03-23 15:51 ` Kalle Valo
2017-03-15 15:46 ` [PATCH v6 10/10] ath10k: sdio support Kalle Valo
2017-03-23 15:23 ` Kalle Valo
2017-03-28 11:53 ` Kalle Valo [this message]
2017-03-28 16:40 ` [PATCH v6 00/10] " Erik Stromdahl
2017-03-29 6:14 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k279wrao.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox