[PATCH] ath10k: suppress 'failed to process fft' warning messages.

[PATCH] ath10k: suppress 'failed to process fft' warning messages.

[Kevin Darbyshire-Bryant]

When using DFS channels on Ath10k, kernel log has repeated warning message
'failed to process fft: -22' typically under medium/heavy traffic.

This patch switches the warnings to driver debug (WMI events) mode only
thus reducing log file noise.

DFS and spectral scan share underlying HW mechanisms and enabling one
(DFS) enables the other (spectral scan) as far as event reporting from
firmware to driver is concerned. Spectral scan events take no part in
processing of DFS radar pulses which are delivered as distinct events,
so the fft (spectral event) warning is harmless and DFS interference
detection/protection still occurs.

Symptoms seen & fix tested in both debug & non-debug modes on TP-Link
Archer C7 v2 platform.

Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
---
 drivers/net/wireless/ath/ath10k/wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index 0791a43..1435614 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -3498,7 +3498,7 @@ void ath10k_wmi_event_spectral_scan(struct ath10k *ar,
 							  fftr, fftr_len,
 							  tsf);
 			if (res < 0) {
-				ath10k_warn(ar, "failed to process fft report: %d\n",
+				ath10k_dbg(ar, ATH10K_DBG_WMI, "failed to process fft report: %d\n",
 					    res);
 				return;
 			}
-- 
1.9.1


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: suppress 'failed to process fft' warning messages.

[Kalle Valo]

Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:

> When using DFS channels on Ath10k, kernel log has repeated warning message
> 'failed to process fft: -22' typically under medium/heavy traffic.
>
> This patch switches the warnings to driver debug (WMI events) mode only
> thus reducing log file noise.
>
> DFS and spectral scan share underlying HW mechanisms and enabling one
> (DFS) enables the other (spectral scan) as far as event reporting from
> firmware to driver is concerned. Spectral scan events take no part in
> processing of DFS radar pulses which are delivered as distinct events,
> so the fft (spectral event) warning is harmless and DFS interference
> detection/protection still occurs.
>
> Symptoms seen & fix tested in both debug & non-debug modes on TP-Link
> Archer C7 v2 platform.
>
> Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>

Thanks, applied.

In the future please use v2, v3 to mark different versions of the patch
so that I can easily find the latest version:

https://www.kernel.org/doc/Documentation/SubmittingPatches

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

[PATCH] ath10k Suppress 'failed to process fft' warning messages.

[Kevin Darbyshire-Bryant]

When using DFS channels on Ath10k kernel log has warning message 'failed
to process fft', typically when under medium/heavy traffic.  Ticket
https://dev.openwrt.org/ticket/19316 discusses and concludes messages
are harmless.  They do still contribute to log noise, so this patch
enables them only in driver debug mode.

Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
---
 drivers/net/wireless/ath/ath10k/wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index 0791a43..1435614 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -3498,7 +3498,7 @@ void ath10k_wmi_event_spectral_scan(struct ath10k *ar,
 							  fftr, fftr_len,
 							  tsf);
 			if (res < 0) {
-				ath10k_warn(ar, "failed to process fft report: %d\n",
+				ath10k_dbg(ar, ATH10K_DBG_WMI, "failed to process fft report: %d\n",
 					    res);
 				return;
 			}
-- 
1.9.1


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k Suppress 'failed to process fft' warning messages.

[Kalle Valo]

Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:

> When using DFS channels on Ath10k kernel log has warning message 'failed
> to process fft', typically when under medium/heavy traffic.  Ticket
> https://dev.openwrt.org/ticket/19316 discusses and concludes messages
> are harmless.  They do still contribute to log noise, so this patch
> enables them only in driver debug mode.
>
> Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>

Don't reference to a discussion somewhere else with a link, instead
summarise the discussion in the commit log.

And please change the title to: ath10k: suppress 'failed to process fft'
warning messages. Also please CC linux-wireless list as instructed here:

https://wireless.wiki.kernel.org/en/users/drivers/ath10k/sources#submitting_patches

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k Suppress 'failed to process fft' warning messages.

[Kevin Darbyshire-Bryant]

[-- Attachment #1.1: Type: text/plain, Size: 1033 bytes --]

On 21/07/15 13:04, Kalle Valo wrote:
> Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk> writes:
>
>> When using DFS channels on Ath10k kernel log has warning message 'failed
>> to process fft', typically when under medium/heavy traffic.  Ticket
>> https://dev.openwrt.org/ticket/19316 discusses and concludes messages
>> are harmless.  They do still contribute to log noise, so this patch
>> enables them only in driver debug mode.
>>
>> Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
> Don't reference to a discussion somewhere else with a link, instead
> summarise the discussion in the commit log.
>
> And please change the title to: ath10k: suppress 'failed to process fft'
> warning messages. Also please CC linux-wireless list as instructed here:
>
> https://wireless.wiki.kernel.org/en/users/drivers/ath10k/sources#submitting_patches
>
Hi Kalle,

Thanks for your feedback.  Sent again with requested changes.  Best I
can do, so hopefully good enough.

Cheers,

Kevin


[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4764 bytes --]

[-- Attachment #2: Type: text/plain, Size: 146 bytes --]

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k