From: Kalle Valo <kvalo@codeaurora.org>
To: Sebastian Gottschall <s.gottschall@newmedia-net.de>
Cc: ath10k@lists.infradead.org
Subject: Re: [PATCH v4 2/3] dt-bindings: net: ath10k: add new dt entry to identify external FEM
Date: Thu, 13 Dec 2018 11:08:42 +0200 [thread overview]
Message-ID: <87o99pztd1.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <a944ea19-fcfe-2ae4-d508-2cde9c34fd29@newmedia-net.de> (Sebastian Gottschall's message of "Tue, 11 Dec 2018 21:07:55 +0100")
Sebastian Gottschall <s.gottschall@newmedia-net.de> writes:
> documentation still wrong. only microsemi-lx5586 is valid .all other
> values are invalid
> see patch 4
>
> + if (!strcmp("microsemi-lx5586", fem_name)) {
> + bb_timing->bb_tx_timing = 0x00;
> + bb_timing->bb_xpa_timing = 0x0101;
> + } else {
> + return -ENOENT;
> + }
Please don't top post, makes the discussion difficult.
But anyway, to my knowledge the device tree is supposed to describe
hardware and not software implementation. So I don't see a problem that
device tree documents FEMs for which ath10k does not do anything right
now.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-12-13 9:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 16:13 [PATCH v4 0/3] ath10k: Add support to configure BB timing for external FEM Bhagavathi Perumal S
2018-12-11 16:13 ` [PATCH v4 1/3] dt-bindings: net: ath10k: fix node name and device type in qcom ath10k example Bhagavathi Perumal S
2018-12-17 21:44 ` Rob Herring
2018-12-20 17:10 ` Kalle Valo
2018-12-11 16:13 ` [PATCH v4 2/3] dt-bindings: net: ath10k: add new dt entry to identify external FEM Bhagavathi Perumal S
2018-12-11 20:07 ` Sebastian Gottschall
[not found] ` <5dd13e00175645e495df16858399d678@euamsexm01f.eu.qualcomm.com>
2018-12-12 4:40 ` Bhagavathi Perumal S
2018-12-12 5:52 ` Bhagavathi Perumal S
2018-12-13 9:08 ` Kalle Valo [this message]
2018-12-17 20:37 ` Rob Herring
2018-12-20 13:23 ` Kalle Valo
2018-12-11 16:13 ` [PATCH v4 3/3] ath10k: Add support to configure BB timing over wmi Bhagavathi Perumal S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o99pztd1.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=s.gottschall@newmedia-net.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox