Re: [PATCH v4 2/3] dt-bindings: net: ath10k: add new dt entry to identify external FEM

[Bhagavathi Perumal S <bperumal@codeaurora.org>]

On 2018-12-12 10:00, Bhagavathi Perumal S wrote:
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of
> Sebastian Gottschall
> Sent: Wednesday, December 12, 2018 1:38 AM
> To: ath10k@lists.infradead.org
> Subject: [EXTERNAL] Re: [PATCH v4 2/3] dt-bindings: net: ath10k: add
> new dt entry to identify external FEM
> 
> documentation still wrong. only  microsemi-lx5586 is valid .all other
> values are invalid see patch 4
> 
> +	if (!strcmp("microsemi-lx5586", fem_name)) {
> +		bb_timing->bb_tx_timing = 0x00;
> +		bb_timing->bb_xpa_timing = 0x0101;
> +	} else {
> +		return -ENOENT;
> +	}
> 

Thanks, Missed it. Need to allow other FEM devices to use default values 
with warning message. Will change it.

> Am 11.12.2018 um 17:13 schrieb Bhagavathi Perumal S:
>> This adds new dt entry ext-fem-name, it is used by ath10k driver to
>> select correct timing parameters and configure it in target wifi 
>> hardware.
>> The Front End Module(FEM) normally includes tx power amplifier(PA) and
>> rx low noise amplifier(LNA). The default timing parameters like tx end
>> to PA off timing values were fine tuned for internal FEM used in
>> reference design. And these timing values can not be same if ODM
>> modifies hardware design with different external FEM. This DT entry
>> helps to choose correct timing values in driver if different external 
>> FEM hardware used.
>> 
>> Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
>> ---
>>   Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 9 
>> ++++++++-
>>   1 file changed, 8 insertions(+), 1 deletion(-)
>> 
>> diff --git
>> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> index ef60f25..71530fd 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> @@ -61,8 +61,14 @@ Optional properties:
>>   	Value type: <phandle>
>>   	Definition: reference to the reserved-memory for the msa region
>>   		    used by the wifi firmware running in Q6.
>> +- ext-fem-name:
>> +	Usage: Optional
>> +	Value type: string
>> +	Definition: Name of external front end module used. Some valid FEM 
>> names
>> +		    for example: "microsemi-lx5586", "sky85703-11"
>> +		    and "sky85803" etc.
>> 
>> -Example (to supply the calibration data alone):
>> +Example (to supply PCI based wifi block details):
>> 
>>   In this example, the node is defined as child node of the PCI 
>> controller.
>> 
>> @@ -77,6 +83,7 @@ pci {
>>   		wifi@0,0 {
>>   			reg = <0 0 0 0 0>;
>>   			qcom,ath10k-calibration-data = [ 01 02 03 ... ];
>> +			ext-fem-name = "microsemi-lx5586";
>>   		};
>>   	};
>>   };
> 
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k