Please add new board files for WLE1216V5-20 and another Compex NIC.

Please add new board files for WLE1216V5-20 and another Compex NIC.

[Ben Greear]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

Hello,

It seems the upstream board-2.bin file for 9984 does not yet include support for WLE1216V5-20
(or possibly it does and OpenWRT grabs the wrong one?).

I'm attaching the board file for this NIC and for another one which
I have not yet tested.  I received these from Compex and have
tested the bus=pci,bmi-chip-id=0,bmi-board-id=31-compex.bin file on the WLE1216V5-20

Please add these into the official board-2.bin for 9984.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


[-- Attachment #2: bus=pci,bmi-chip-id=0,bmi-board-id=31-compex.bin --]
[-- Type: application/x-macbinary, Size: 12064 bytes --]

[-- Attachment #3: bus=pci,bmi-chip-id=0,bmi-board-id=30-compex.bin --]
[-- Type: application/x-macbinary, Size: 12064 bytes --]

[-- Attachment #4: Type: text/plain, Size: 146 bytes --]

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Please add new board files for WLE1216V5-20 and another Compex NIC.

[Tim Harvey]

On Wed, Mar 21, 2018 at 2:59 PM, Ben Greear <greearb@candelatech.com> wrote:
> Hello,
>
> It seems the upstream board-2.bin file for 9984 does not yet include support
> for WLE1216V5-20
> (or possibly it does and OpenWRT grabs the wrong one?).
>
> I'm attaching the board file for this NIC and for another one which
> I have not yet tested.  I received these from Compex and have
> tested the bus=pci,bmi-chip-id=0,bmi-board-id=31-compex.bin file on the
> WLE1216V5-20
>
> Please add these into the official board-2.bin for 9984.
>

Kalle,

Any progress on this? I believe your the one that has to update the
board-2.bin at https://github.com/kvalo/ath10k-firmware/commits/master/QCA9984/hw1.0.

It's not clear what the process is for getting new board id's
supported in the board.bin files.

Regards,

Tim

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Please add new board files for WLE1216V5-20 and another Compex NIC.

[Sven Eckelmann]

[-- Attachment #1.1: Type: text/plain, Size: 2623 bytes --]

On Mittwoch, 11. April 2018 08:18:15 CEST Tim Harvey wrote:
> It's not clear what the process is for getting new board id's
> supported in the board.bin files.

The reaction of QCA when asking for new IDs was mostly "please go away, we 
will not talk to you about it". But with the help of Kalle Valo, a new 
mechanism called "qcom,ath10k-calibration-variant" was added (for embedded 
boards which include QCA 11ac wave2 radios). There are a couple of mails 
about it on this list - a general overview about BDFs, variant strings and 
why we need them can be found at 
http://lists.infradead.org/pipermail/ath10k/2018-March/011066.html.

But it looks like you really got the IDs 30+31 (maybe because you are selling 
the, as separate PCIe modules?). Then I would guess that you can still use the 
same process as we use for the accesspoint specific BDFs (just without the 
variant= part).

The description of the general upstreaming process can be found at 
https://wireless.wiki.kernel.org/en/users/drivers/ath10k/boardfiles - but it 
seems like Kalle Valo doesn't have much time for it at the moment for it (or
there might be other problems which we don't see from our perspective - for 
example legal departments).

Maybe you or Ben Greear can enhance the submission for the BDFs to better 
answer the questions from the "Submitting board files" guide. 


Examples for such submission
============================

* OpenMesh A42

  - applied
  - http://lists.infradead.org/pipermail/ath10k/2017-November/010470.html
  - http://lists.infradead.org/pipermail/ath10k/2017-December/010543.html

* Asus RT-AC58U

  - not yet accepted
  - submitted before the guide was published
  - http://lists.infradead.org/pipermail/ath10k/2017-March/009454.html

* Netgear EX6100v2/EX6150v2

  - not yet accepted
  - http://lists.infradead.org/pipermail/ath10k/2018-February/010845.html

* 8devices Jalapeno

  - not yet accepted
  - http://lists.infradead.org/pipermail/ath10k/2018-March/010916.html

* GL.iNet GL-B1300

  - not yet accepted
  - http://lists.infradead.org/pipermail/ath10k/2018-March/011058.html

* OpenMesh A62

  - not yet accepted
  - http://lists.infradead.org/pipermail/ath10k/2018-March/011081.html



Still waiting for send BDFs to upstream
=======================================

* Meraki MR33

  - Chris Blake?
  - https://github.com/openwrt/openwrt/blob/master/package/firmware/ipq-wifi/board-meraki_mr33.bin

* Fritzbox 4040

  - Christian Lamparter?
  - https://github.com/openwrt/openwrt/blob/master/package/firmware/ipq-wifi/board-avm_fritzbox-4040.bin

* maybe more which I missed


Kind regards,
	Sven

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 146 bytes --]

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Please add new board files for WLE1216V5-20 and another Compex NIC.

[Ben Greear]

On 04/12/2018 12:27 AM, Sven Eckelmann wrote:
> On Mittwoch, 11. April 2018 08:18:15 CEST Tim Harvey wrote:
>> It's not clear what the process is for getting new board id's
>> supported in the board.bin files.
>
> The reaction of QCA when asking for new IDs was mostly "please go away, we
> will not talk to you about it". But with the help of Kalle Valo, a new
> mechanism called "qcom,ath10k-calibration-variant" was added (for embedded
> boards which include QCA 11ac wave2 radios). There are a couple of mails
> about it on this list - a general overview about BDFs, variant strings and
> why we need them can be found at
> http://lists.infradead.org/pipermail/ath10k/2018-March/011066.html.
>
> But it looks like you really got the IDs 30+31 (maybe because you are selling
> the, as separate PCIe modules?). Then I would guess that you can still use the
> same process as we use for the accesspoint specific BDFs (just without the
> variant= part).

These are Compex NICs, and they do have their own IDs.  These are general
purpose NICs that fit into most any system, so it would be good if the board
files were in the upstream board-2.bin file.

> The description of the general upstreaming process can be found at
> https://wireless.wiki.kernel.org/en/users/drivers/ath10k/boardfiles - but it
> seems like Kalle Valo doesn't have much time for it at the moment for it (or
> there might be other problems which we don't see from our perspective - for
> example legal departments).
>
> Maybe you or Ben Greear can enhance the submission for the BDFs to better
> answer the questions from the "Submitting board files" guide.

Considering all of the not-accepted below, maybe we should just build
our own board file(s) for OpenWRT and let upstream catch up when someone
has time to deal with it?

For platform specific files, maybe better to just ignore the board-2.bin
entirely and use the specific board.bin file for that platform?

Thanks,
Ben

>
>
> Examples for such submission
> ============================
>
> * OpenMesh A42
>
>   - applied
>   - http://lists.infradead.org/pipermail/ath10k/2017-November/010470.html
>   - http://lists.infradead.org/pipermail/ath10k/2017-December/010543.html
>
> * Asus RT-AC58U
>
>   - not yet accepted
>   - submitted before the guide was published
>   - http://lists.infradead.org/pipermail/ath10k/2017-March/009454.html
>
> * Netgear EX6100v2/EX6150v2
>
>   - not yet accepted
>   - http://lists.infradead.org/pipermail/ath10k/2018-February/010845.html
>
> * 8devices Jalapeno
>
>   - not yet accepted
>   - http://lists.infradead.org/pipermail/ath10k/2018-March/010916.html
>
> * GL.iNet GL-B1300
>
>   - not yet accepted
>   - http://lists.infradead.org/pipermail/ath10k/2018-March/011058.html
>
> * OpenMesh A62
>
>   - not yet accepted
>   - http://lists.infradead.org/pipermail/ath10k/2018-March/011081.html
>
>
>
> Still waiting for send BDFs to upstream
> =======================================
>
> * Meraki MR33
>
>   - Chris Blake?
>   - https://github.com/openwrt/openwrt/blob/master/package/firmware/ipq-wifi/board-meraki_mr33.bin
>
> * Fritzbox 4040
>
>   - Christian Lamparter?
>   - https://github.com/openwrt/openwrt/blob/master/package/firmware/ipq-wifi/board-avm_fritzbox-4040.bin
>
> * maybe more which I missed
>
>
> Kind regards,
> 	Sven
>


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Please add new board files for WLE1216V5-20 and another Compex NIC.

[Kalle Valo]

Tim Harvey <tharvey@gateworks.com> writes:

> On Wed, Mar 21, 2018 at 2:59 PM, Ben Greear <greearb@candelatech.com> wrote:
>> Hello,
>>
>> It seems the upstream board-2.bin file for 9984 does not yet include support
>> for WLE1216V5-20
>> (or possibly it does and OpenWRT grabs the wrong one?).
>>
>> I'm attaching the board file for this NIC and for another one which
>> I have not yet tested.  I received these from Compex and have
>> tested the bus=pci,bmi-chip-id=0,bmi-board-id=31-compex.bin file on the
>> WLE1216V5-20
>>
>> Please add these into the official board-2.bin for 9984.
>>
>
> Kalle,
>
> Any progress on this? I believe your the one that has to update the
> board-2.bin at
> https://github.com/kvalo/ath10k-firmware/commits/master/QCA9984/hw1.0.

This is on my queue but I don't update board files that often, due to
lack of time. But I'll try to get to this request in the next few days.

> It's not clear what the process is for getting new board id's
> supported in the board.bin files.

I think Sven already provided the link to the wiki page.

-- 
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Please add new board files for WLE1216V5-20 and another Compex NIC.

[Kalle Valo]

Ben Greear <greearb@candelatech.com> writes:

> It seems the upstream board-2.bin file for 9984 does not yet include
> support for WLE1216V5-20 (or possibly it does and OpenWRT grabs the
> wrong one?).
>
> I'm attaching the board file for this NIC and for another one which I
> have not yet tested. I received these from Compex and have tested the
> bus=pci,bmi-chip-id=0,bmi-board-id=31-compex.bin file on the
> WLE1216V5-20
>
> Please add these into the official board-2.bin for 9984.

Are these the actual board names I should use:

bus=pci,bmi-chip-id=0,bmi-board-id=31
bus=pci,bmi-chip-id=0,bmi-board-id=30

In the attached filenames you have the -compex suffix but I don't think
I should use those:

[2. application/x-macbinary; bus=pci,bmi-chip-id=0,bmi-board-id=31-compex.bin]...
[3. application/x-macbinary; bus=pci,bmi-chip-id=0,bmi-board-id=30-compex.bin]...

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Please add new board files for WLE1216V5-20 and another Compex NIC.

[Ben Greear]

On 04/18/2018 09:42 AM, Kalle Valo wrote:
> Ben Greear <greearb@candelatech.com> writes:
>
>> It seems the upstream board-2.bin file for 9984 does not yet include
>> support for WLE1216V5-20 (or possibly it does and OpenWRT grabs the
>> wrong one?).
>>
>> I'm attaching the board file for this NIC and for another one which I
>> have not yet tested. I received these from Compex and have tested the
>> bus=pci,bmi-chip-id=0,bmi-board-id=31-compex.bin file on the
>> WLE1216V5-20
>>
>> Please add these into the official board-2.bin for 9984.
>
> Are these the actual board names I should use:
>
> bus=pci,bmi-chip-id=0,bmi-board-id=31
> bus=pci,bmi-chip-id=0,bmi-board-id=30

Yes, I think so.  If you want to send me the bin file your tools create
before you commit, I will be happy to load it on my system with the compex
NIC and make sure it works as expected.

Thanks,
Ben

>
> In the attached filenames you have the -compex suffix but I don't think
> I should use those:
>
> [2. application/x-macbinary; bus=pci,bmi-chip-id=0,bmi-board-id=31-compex.bin]...
> [3. application/x-macbinary; bus=pci,bmi-chip-id=0,bmi-board-id=30-compex.bin]...
>


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Please add new board files for WLE1216V5-20 and another Compex NIC.

[Kalle Valo]

Ben Greear <greearb@candelatech.com> writes:

> It seems the upstream board-2.bin file for 9984 does not yet include
> support for WLE1216V5-20
> (or possibly it does and OpenWRT grabs the wrong one?).
>
> I'm attaching the board file for this NIC and for another one which
> I have not yet tested.  I received these from Compex and have
> tested the bus=pci,bmi-chip-id=0,bmi-board-id=31-compex.bin file on the WLE1216V5-20
>
> Please add these into the official board-2.bin for 9984.

Added, but please check carefully that I didn't do any mistakes.

https://github.com/kvalo/ath10k-firmware/commit/66be3a48d9cf17ace8413cf478a5954483393af4

New:
bus=pci,bmi-chip-id=0,bmi-board-id=30

Changed:


Deleted:

1 board image(s) added, 0 changed, 0 deleted, 11 in total

New:
bus=pci,bmi-chip-id=0,bmi-board-id=31

Changed:


Deleted:

1 board image(s) added, 0 changed, 0 deleted, 12 in total

-- 
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Please add new board files for WLE1216V5-20 and another Compex NIC.

[Kalle Valo]

Kalle Valo <kvalo@qca.qualcomm.com> writes:

> Ben Greear <greearb@candelatech.com> writes:
>
>> It seems the upstream board-2.bin file for 9984 does not yet include
>> support for WLE1216V5-20
>> (or possibly it does and OpenWRT grabs the wrong one?).
>>
>> I'm attaching the board file for this NIC and for another one which
>> I have not yet tested.  I received these from Compex and have
>> tested the bus=pci,bmi-chip-id=0,bmi-board-id=31-compex.bin file on the WLE1216V5-20
>>
>> Please add these into the official board-2.bin for 9984.
>
> Added, but please check carefully that I didn't do any mistakes.
>
> https://github.com/kvalo/ath10k-firmware/commit/66be3a48d9cf17ace8413cf478a5954483393af4

That's obviously the wrong commit, this is the correct one:

https://github.com/kvalo/ath10k-firmware/commit/b1dd338046a385743c483a47e8eef276adaba0c0

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Please add new board files for WLE1216V5-20 and another Compex NIC.

[Ben Greear]

On 04/19/2018 03:10 AM, Kalle Valo wrote:
> Kalle Valo <kvalo@qca.qualcomm.com> writes:
>
>> Ben Greear <greearb@candelatech.com> writes:
>>
>>> It seems the upstream board-2.bin file for 9984 does not yet include
>>> support for WLE1216V5-20
>>> (or possibly it does and OpenWRT grabs the wrong one?).
>>>
>>> I'm attaching the board file for this NIC and for another one which
>>> I have not yet tested.  I received these from Compex and have
>>> tested the bus=pci,bmi-chip-id=0,bmi-board-id=31-compex.bin file on the WLE1216V5-20
>>>
>>> Please add these into the official board-2.bin for 9984.
>>
>> Added, but please check carefully that I didn't do any mistakes.
>>
>> https://github.com/kvalo/ath10k-firmware/commit/66be3a48d9cf17ace8413cf478a5954483393af4
>
> That's obviously the wrong commit, this is the correct one:
>
> https://github.com/kvalo/ath10k-firmware/commit/b1dd338046a385743c483a47e8eef276adaba0c0
>

It appears to be working with WLE1216V5-20.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k