From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Ben Greear <greearb@candelatech.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
"sw@simonwunderlich.de" <sw@simonwunderlich.de>
Subject: Re: [PATCH 1/2] ath10k: introduce a stricter scan state machine
Date: Tue, 29 Jul 2014 12:51:17 +0300 [thread overview]
Message-ID: <87wqawh4ru.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQnMKDCPTOZswZTg8s-_hmaKBiwDT_Rj4tt=ReR7RUWQ3w@mail.gmail.com> (Michal Kazior's message of "Tue, 29 Jul 2014 11:46:48 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
>>> @@ -2323,8 +2348,6 @@ void ath10k_halt(struct ath10k *ar)
>>> ath10k_monitor_stop(ar);
>>> }
>>>
>>> - del_timer_sync(&ar->scan.timeout);
>>> - ath10k_reset_scan((unsigned long)ar);
>>> ath10k_peer_cleanup_all(ar);
>>> ath10k_core_stop(ar);
>>> ath10k_hif_power_down(ar);
>>
>> Why you don't call ath10k_scan_reset() here? I would have assumed that
>> you do that.
>
> Hmm.. Good catch.
>
> Anyway I need to work on this patch a little bit more and fix another
> corner case.
Ok, I'll drop this patch and wait for the next version.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-07-29 9:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 11:11 [PATCH 0/2] ath10k: scan fixes 2014-07-21 Michal Kazior
2014-07-21 11:11 ` [PATCH 1/2] ath10k: introduce a stricter scan state machine Michal Kazior
2014-07-29 9:20 ` Kalle Valo
2014-07-29 9:46 ` Michal Kazior
2014-07-29 9:51 ` Kalle Valo [this message]
2014-07-21 11:11 ` [PATCH 2/2] ath10k: simplify scan debug prints Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqawh4ru.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox